-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passt stability tests #4062
passt stability tests #4062
Conversation
Hit error: |
Sorry for the replay later, this problem has been fixed. Please help review it again if you have free time. |
test got failed on s390x and I've paste the log in jira issue |
Hi @fbq815 First, thanks for your help review, but according to you test log you are still using the tap device instead of passt, so test failed. I will write a test steps for this ASAP, please help review it again that time. Thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't see any code related to passt, and almost code are copied from iperf test.
Hi @PaulYuuu Could you please help review this patch again? Thanks a lot. |
I don't see you fix the problem, please double-check. |
Let me reply this question on the patch which like we disscuss it offline in the past. Due passt only as a network backend, so for tests only forcus on the different iperf parameters and transfer method for iperf source package. The steps for compiling iperf and running the test are indeed copied from the iperf test, there are two reasons: first and most important, we can't just write a cfg and reuse the iperf test python file directly that would make the original file unrecognizable. , because this is limited by the usage of passt. The second point is also related to the first point. Writing a new one directly will make the automation complete quickly because it will not affect others and will facilitate future maintenance. |
For now, I think I fixed all problems, so please help review it again. Thanks a lot. |
Hi @PaulYuuu Please help me review this patch again, thanks a lot. It can test pass on my side. |
Hello @fbq815, any comment for the latest update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
qemu.passt_stability_tests.with_tcp.s390-virtio: PASS (257.80 s)
qemu.passt_stability_tests.with_udp.s390-virtio: PASS (248.59 s)
Add a new case to support passt stability tests. Signed-off-by: Lei Yang <[email protected]>
Add a new case to support passt stability tests.
ID:2445
Signed-off-by: Lei Yang [email protected]