Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdump: Update kdump kernel_param_cmd command for different OS version #4146

Merged
merged 2 commits into from
Oct 18, 2024
Merged

kdump: Update kdump kernel_param_cmd command for different OS version #4146

merged 2 commits into from
Oct 18, 2024

Conversation

heywji
Copy link
Contributor

@heywji heywji commented Aug 29, 2024 •
edited
Loading

Based on RHEL-41849, the crashkernel=auto parameter is no longer supported in the latest RHEL versions. We should use the kdumpctl reset-crashkernel command to reset crashkernel values to our default settings.

ID: 2654
Signed-off-by: wji [email protected]

@heywji
Copy link
Contributor Author

heywji commented Aug 29, 2024

Hi @MiriamDeng and @fbq815,

Would you guys want to check multi-arch for this part?

Thanks in advance,
Wecom

@heywji
Copy link
Contributor Author

heywji commented Aug 29, 2024

Test Result

 (01/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (01/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (547.68 s)
 (02/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
 (02/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (701.04 s)
 (03/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.q35: STARTED
 (03/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.q35: PASS (142.87 s)
 (04/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.nmi.q35: STARTED
 (04/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.nmi.q35: PASS (143.83 s)
 (05/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.q35: STARTED
 (05/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.q35: PASS (175.05 s)
 (06/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi.q35: STARTED
 (06/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi.q35: PASS (181.65 s)
 (07/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.q35: STARTED
 (07/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.q35: PASS (160.20 s)
 (08/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi.q35: STARTED
 (08/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi.q35: PASS (156.00 s)
 (09/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.q35: STARTED
 (09/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.q35: PASS (176.40 s)
 (10/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi.q35: STARTED

 (10/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi.q35: FAIL: Could not found vmcore file. (341.25 s)
 (11/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.q35: STARTED
 (11/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.q35: PASS (185.11 s)
 (12/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.nmi.q35: STARTED
 (12/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.nmi.q35: PASS (187.39 s)
 (13/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.q35: STARTED
 (13/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.q35: PASS (166.73 s)
 (14/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.nmi.q35: STARTED
 (14/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.nmi.q35: PASS (166.26 s)
 (15/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.q35: STARTED
 (15/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.q35: PASS (191.87 s)
 (16/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi.q35: STARTED
 (16/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi.q35: PASS (199.69 s)
 (17/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.q35: STARTED
 (17/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.q35: PASS (175.75 s)
 (18/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi.q35: STARTED
 (18/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi.q35: PASS (162.43 s)
 (19/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.q35: STARTED
 (19/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.q35: FAIL: Could not found vmcore file. (352.70 s)
 (20/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi.q35: STARTED
 (20/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi.q35: FAIL: Could not found vmcore file. (352.80 s)
 (21/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.q35: STARTED
 (21/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.q35: PASS (194.35 s)
 (22/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.nmi.q35: STARTED
 (22/22) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.kdump.multi_vms.nmi.q35: PASS (178.62 s)
RESULTS    : PASS 19 | ERROR 0 | FAIL 3 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

The above three failures are known issues.

fbq815
fbq815 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
RESULTS : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@MiriamDeng
Copy link
Contributor

The patch looks good to me from code view. Hi @maxujun, could you please give a hand to try it on ppc side as you are the only person working on it now ? Thank you ! :)

@maxujun
Copy link
Contributor

maxujun commented Sep 26, 2024

(01/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm: STARTED
(01/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm: PASS (174.57 s)
(02/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.nmi: STARTED
(02/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.nmi: PASS (137.93 s)
(03/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress: STARTED
(03/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress:PASS (173.21 s)
(04/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi: STARTED
(04/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi: PASS (189.24 s)
(05/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress: STARTED
(05/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress: PASS (153.37 s)
(06/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi: STARTED
(06/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi: PASS (152.97 s)
(07/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh: STARTED
(07/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh: PASS (205.26 s)
(08/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi: STARTED
(08/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi: PASS (187.78 s)
(09/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms: STARTED
(09/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms: PASS (226.54 s)
(10/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms.nmi: STARTED
(10/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.10.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms.nmi: PASS (229.67 s)
(11/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm: STARTED
(11/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm: PASS (289.65 s)
(12/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.nmi: STARTED
(12/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.nmi: PASS (245.89 s)
(13/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress: STARTED
(13/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress: PASS (311.64 s)
(14/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi: STARTED
(14/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.netperf_stress.nmi: PASS (292.49 s)
(15/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress: STARTED
(15/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress: PASS (214.97 s)
(16/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi: STARTED
(16/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_stress.io_stress.nmi: PASS (259.22 s)
(17/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh: STARTED
(17/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh: PASS (248.48 s)
(18/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi: STARTED
(18/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.one_vm.with_ssh.nmi: PASS (258.00 s)
(19/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms: STARTED
(19/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms: PASS (361.79 s)
(20/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms.nmi: STARTED
(20/20) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.ppc64le.io-github-autotest-qemu.kdump.multi_vms.nmi: PASS (263.85 s)

LGTM，Acked.

leidwang
leidwang approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@heywji
Copy link
Contributor Author

heywji commented Oct 9, 2024

Hi @vivianQizhu, Could you help review this as well? Thanks : )

@heywji
kdump: Update kdump kernel_param_cmd command for different OS version
e057141 
Based on RHEL-41849, the `crashkernel=auto` parameter is no longer supported in
the latest RHEL versions. We should use the `kdumpctl reset-crashkernel`
command to reset crashkernel values to our default settings.

Signed-off-by: wji <[email protected]>
@vivianQizhu vivianQizhu merged commit 855202e into autotest:master Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivianQizhu vivianQizhu vivianQizhu approved these changes

@fbq815 fbq815 fbq815 approved these changes

@leidwang leidwang leidwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@heywji @MiriamDeng @maxujun @vivianQizhu @fbq815 @leidwang