Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_fs_share_data_hugepage: correct the argument #4188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

virtio_fs_share_data_hugepage: correct the argument #4188

wants to merge 1 commit into from

Conversation

zhaojunyao7
Copy link

KVMAUTOMA-2917-[KVM_AUTOTEST]virtio_fs_share_data_hugepage..with_cache. cases failed because of our new avocado fix

[stdlog] 2024-10-11 04:33:28,979 avocado.virttest.qemu_devices.qdevices qdevices L2150 INFO | Running virtiofs daemon command /usr/libexec/virtiofsd --socket-path=/var/tmp/avocado_l679k6k3/avocado-vt-vm1-fs-virtiofsd.sock --shared-dir /root/avocado/data/avocado-vt/virtio_fs_test/,cache=auto.

should be "--cache=auto" other than ",cache=auto"

@zhaojunyao7
Copy link
Author

@hellohellenmao , please help review this. Thanks.

@zhaojunyao7 zhaojunyao7 force-pushed the KVMAUTOMA-2917 branch 3 times, most recently from c968ab9 to 682bdac Compare October 30, 2024 09:12
@zhaojunyao7 zhaojunyao7 changed the title virtio_fs_share_data_hugepage: correct the argument passing for --cache in virtiofsd command virtio_fs_share_data_hugepage: correct the argument Oct 30, 2024
@zhaojunyao7
Copy link
Author

(1/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.auto.q35: STARTED
(1/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.auto.q35: PASS (88.74 s)
(2/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.always.q35: STARTED
(2/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.always.q35: PASS (86.93 s)
(3/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.none.q35: STARTED
(3/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.none.q35: PASS (87.84 s)
(4/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.auto.q35: STARTED
(4/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.auto.q35: PASS (85.15 s)
(5/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.always.q35: STARTED
(5/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.always.q35: PASS (135.45 s)
(6/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.none.q35: STARTED
(6/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.with_numa.basic_test.with_cache.none.q35: PASS (86.39 s)
RESULTS : PASS 6 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

hellohellenmao
hellohellenmao approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@hellohellenmao hellohellenmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellohellenmao
Copy link
Contributor

@YongxueHong Could you please help to take a review here? Thanks.

@YongxueHong
Copy link
Contributor

Hi @zhaojunyao7
Thanks for your contribution.
There is a guide on how to write a better commit for a PR: https://avocado-framework.readthedocs.io/en/62.0/ContributionGuide.html

Write a good commit message, pointing motivation, issues that you’re addressing. Usually you should try to explain 3 points in the commit message: motivation, approach and effects:

header          <- Limited to 72 characters. No period.
                <- Blank line
message         <- Any number of lines, limited to 72 characters per line.
                <- Blank line
Reference:      <- External references, one per line (issue, trello, ...)
Signed-off-by:  <- Signature and acknowledgment of licensing terms when
                   contributing to the project (created by git commit -s)

Could you help to update your commit with the above reference? Thanks in advance.
BTW, regarding the conversation 0 , maybe you need to update it with a special format:

# Description your PR, you could refer to your commit message
ID: $jira id

There is an example for you: #4189

@zhaojunyao7
virtio_fs_share_data_hugepage: correct the argument
7d72b42 
passing for --cache in virtiofsd command from ,cache= to --cache=

ID: KVMAUTOMA-2917
Signed-off-by: Junyao Zhao <[email protected]>
@zhaojunyao7
Copy link
Author

@YongxueHong Thanks for your guidance. I updated the issue id. Please help check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohellenmao hellohellenmao hellohellenmao approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaojunyao7 @hellohellenmao @YongxueHong