Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(localization): add note for non-NDT users #496

Conversation

KYabuuchi
Copy link
Contributor

Description

I added a note to users who use pose_estimator other than NDT.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <[email protected]>
@KYabuuchi KYabuuchi requested a review from Motsu-san December 6, 2023 08:59
@KYabuuchi KYabuuchi added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:localization Vehicle's position determination in its environment. labels Dec 6, 2023
@KYabuuchi KYabuuchi marked this pull request as ready for review December 6, 2023 09:02
Signed-off-by: Kento Yabuuchi <[email protected]>
@Motsu-san
Copy link

LGTMeow

@KYabuuchi KYabuuchi merged commit 3d1e6ce into autowarefoundation:main Dec 18, 2023
8 checks passed
@KYabuuchi KYabuuchi deleted the feat/not_ndt_localizer_causes_stale_diag branch December 18, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants