Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the perception design document and the interface document #499

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Dec 7, 2023

Description

Improve the documentation related to the perception module.

  • Perception sub-components sescription: Add examples of object recognition and obstacle segmentation.
  • Update perception output description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shunsuke Miura <[email protected]>
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 7, 2023
Signed-off-by: Shunsuke Miura <[email protected]>
@miursh miursh requested a review from Shin-kyoto December 8, 2023 06:33
@miursh
Copy link
Contributor Author

miursh commented Dec 8, 2023

@Shin-kyoto
I revised the wording. 8454221
Could you review again?

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 913ba9a into main Dec 8, 2023
8 checks passed
@miursh miursh deleted the docs/update_dynamic_object_description branch December 8, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants