Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrating autoware): fix the wrong name in creating sensor model #505

Merged

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Jan 9, 2024

Description

On the page Creating a sensor model for Autoware. Some small naming mistakes might confuse the user.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf
Copy link
Contributor Author

vividf commented Jan 9, 2024

@ismetatabay @kenji-miyake @drwnz
Could you review this PR :)
Thanks!

Copy link
Member

@ismetatabay ismetatabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismetatabay
Copy link
Member

@vividf Thanks for the PR!

@ismetatabay ismetatabay merged commit 54092c2 into autowarefoundation:main Jan 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants