Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the carla simulator page under digital twin #517

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

evshary
Copy link
Member

@evshary evshary commented Feb 7, 2024

Description

Add the Carla simulator page, which includes several projects able to bridge Autoware and Carla.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@evshary
Copy link
Member Author

evshary commented Feb 7, 2024

Before merging the PR, I'll ask the community to add more projects to the pages.

@evshary evshary changed the title Add the Carla simulator page under Digital Twin docs: Add the Carla simulator page under Digital Twin Feb 7, 2024
Signed-off-by: ChenYing Kuo <[email protected]>
@evshary evshary changed the title docs: Add the Carla simulator page under Digital Twin docs: add the carla simulator page under digital twin Feb 7, 2024
@evshary evshary marked this pull request as ready for review February 16, 2024 01:41
@evshary
Copy link
Member Author

evshary commented Feb 16, 2024

I have asked for permission to put other projects on the page.
https://github.com/orgs/autowarefoundation/discussions/3391#discussioncomment-8391628
https://github.com/orgs/autowarefoundation/discussions/2828#discussioncomment-8408457
I think it's ready for review now.

@kminoda kminoda added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 16, 2024
@evshary
Copy link
Member Author

evshary commented Mar 5, 2024

Hi @mitsudome-r
It would be great if you could take a look at the changes.
Please let me know if you have any comments. Thank you.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evshary evshary merged commit a504e47 into autowarefoundation:main Mar 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants