Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-types/point-cloud): fix document of return_type #540

Closed

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Apr 23, 2024

Description

This PR is for adding a note to return_type.
Because of this PR, padding will be added in PointXYZIRC (possibly change).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@a-maumau a-maumau marked this pull request as ready for review April 23, 2024 09:32
@xmfcx
Copy link
Contributor

xmfcx commented May 2, 2024

See my comments here:

This won't be changed because once the intensity is reduced to a single byte, this won't be necessary.

@xmfcx xmfcx closed this May 2, 2024
@a-maumau a-maumau deleted the fix/data-types/point-cloud branch May 7, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants