Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_simple_pure_pursuit package #140

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link

@takayuki5168 takayuki5168 commented Dec 24, 2024

Description

Added a simple_pure_pursuit for the Autoware.Core's default controller

Related links

https://github.com/orgs/autowarefoundation/discussions/5365

How was this PR tested?

No tests are applied at all since the launch files are not prepared yet.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 9, 2025
@takayuki5168 takayuki5168 marked this pull request as ready for review February 25, 2025 07:59
@takayuki5168 takayuki5168 force-pushed the feat/tmp-simple-pure-pursuit branch from 07c62c1 to 2c176b2 Compare February 25, 2025 08:16
@takayuki5168 takayuki5168 requested a review from a team as a code owner February 25, 2025 08:16
@youtalk
Copy link
Member

youtalk commented Feb 26, 2025

@takayuki5168 First of all, please pass the 3 failing checks.

@takayuki5168 takayuki5168 force-pushed the feat/tmp-simple-pure-pursuit branch from 2c176b2 to 57c0cad Compare February 26, 2025 00:39
@takayuki5168
Copy link
Author

takayuki5168 commented Feb 26, 2025

@youtalk
I was asked by @mitsudome-r -san to make this PR ready for review, but this PR is incomplete since the dependent packages are still in the autoware.universe, and with these changes, another CI failures may occur. That's why I ignore the minor CI failures for now.
I'm fine with making this PR draft again if you want.

→ By removing the unnecessary commit, I found that the CI failure is only a build error. 😄

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2025

Could you list the packages this depends that are in autoware_universe?

@takayuki5168
Copy link
Author

@xmfcx
I think it's only the autoware_universe_utils, and it was ported to the autoware_utils just yesterday.
autowarefoundation/autoware_utils#30

I will fix this PR based on the above changes.

takayuki5168 and others added 7 commits February 26, 2025 16:58
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
* add unit tests

Signed-off-by: mitukou1109 <[email protected]>

* add test for calc_longitudinal_control

Signed-off-by: mitukou1109 <[email protected]>

* rename calc_steering_angle to calc_lateral_control

Signed-off-by: mitukou1109 <[email protected]>

---------

Signed-off-by: mitukou1109 <[email protected]>
* add parameter description

Signed-off-by: mitukou1109 <[email protected]>

* add README

Signed-off-by: mitukou1109 <[email protected]>

---------

Signed-off-by: mitukou1109 <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@xmfcx xmfcx added the type:new-feature New functionalities or additions, feature requests. label Feb 26, 2025
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/tmp-simple-pure-pursuit branch from 57c0cad to c0d5512 Compare February 26, 2025 08:01
@xmfcx xmfcx marked this pull request as draft February 26, 2025 10:07
@xmfcx xmfcx requested a review from mitsudome-r February 26, 2025 10:07
@xmfcx xmfcx assigned takayuki5168 and unassigned mitsudome-r Feb 26, 2025
Signed-off-by: Takayuki Murooka <[email protected]>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 81.08108% with 21 lines in your changes missing coverage. Please review.

Project coverage is 1.66%. Comparing base (4cb18f5) to head (0de2e0a).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
...re_simple_pure_pursuit/src/simple_pure_pursuit.cpp 81.03% 9 Missing and 2 partials ⚠️
...ple_pure_pursuit/test/test_simple_pure_pursuit.cpp 81.13% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #140       +/-   ##
==========================================
- Coverage   78.75%   1.66%   -77.10%     
==========================================
  Files          11      65       +54     
  Lines         193    8489     +8296     
  Branches       73     824      +751     
==========================================
- Hits          152     141       -11     
- Misses         11    8328     +8317     
+ Partials       30      20       -10     
Flag Coverage Δ
differential 1.66% <81.08%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@takayuki5168
Copy link
Author

@xmfcx @mitsudome-r
Seems that the failure of the pre-commit comes from the other package. Other than that, the required CI passed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants