Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_qp_interface): porting autoware_qp_interface package from autoware.universe #146

Merged

Conversation

NorahXiong
Copy link
Contributor

@NorahXiong NorahXiong commented Jan 2, 2025

Description

Fetch autoware_qp_interface from autoware.universe.

Related links

Should be handled together with #9824

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it’s a porting task, I’m keeping the review to a minimum.

common/autoware_qp_interface/CHANGELOG.rst Outdated Show resolved Hide resolved
common/autoware_qp_interface/package.xml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 55.30035% with 253 lines in your changes missing coverage. Please review.

Project coverage is 61.26%. Comparing base (4cb18f5) to head (4e3881e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ommon/autoware_qp_interface/src/osqp_interface.cpp 42.30% 95 Missing and 10 partials ⚠️
...utoware_qp_interface/test/test_csc_matrix_conv.cpp 26.11% 1 Missing and 98 partials ⚠️
...mon/autoware_qp_interface/src/proxqp_interface.cpp 61.97% 24 Missing and 3 partials ⚠️
common/autoware_qp_interface/src/qp_interface.cpp 50.00% 5 Missing and 5 partials ⚠️
...autoware_qp_interface/test/test_osqp_interface.cpp 92.40% 1 Missing and 5 partials ⚠️
...toware_qp_interface/test/test_proxqp_interface.cpp 76.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #146       +/-   ##
===========================================
- Coverage   78.75%   61.26%   -17.50%     
===========================================
  Files          11       20        +9     
  Lines         193      759      +566     
  Branches       73      412      +339     
===========================================
+ Hits          152      465      +313     
- Misses         11      137      +126     
- Partials       30      157      +127     
Flag Coverage Δ *Carryforward flag
differential 55.30% <55.30%> (?)
total 78.75% <ø> (ø) Carriedforward from b2eae23

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NorahXiong NorahXiong force-pushed the porting/autoware_qp_interface branch from 155e821 to b2eae23 Compare January 13, 2025 01:55
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit d02e32a into autowarefoundation:main Jan 15, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants