Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_point_types from autoware.universe #151

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Jan 6, 2025

Description

Port autoware_point_types from Autoware.Universe.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk enabled auto-merge (squash) January 8, 2025 08:37
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (4cb18f5) to head (ad9e70f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...mon/autoware_point_types/test/test_point_types.cpp 82.35% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   78.75%   80.53%   +1.77%     
==========================================
  Files          11       13       +2     
  Lines         193      226      +33     
  Branches       73       88      +15     
==========================================
+ Hits          152      182      +30     
  Misses         11       11              
- Partials       30       33       +3     
Flag Coverage Δ *Carryforward flag
differential 90.90% <90.90%> (?)
total 78.75% <ø> (ø) Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youtalk youtalk merged commit 871106e into autowarefoundation:main Jan 8, 2025
25 of 26 checks passed
@mitsudome-r
Copy link
Member

mitsudome-r commented Jan 8, 2025

@cyn-liu Thanks for creating the package removal PR in Universe.

@youtalk Thanks for the review. Just to make sure that we don't break the build for main branches (autoware-nightly.repos), let's avoid using the auto-merge and make sure that we manually merge the package porting PR in Autoware Core and package removal PR in Autoware Universe at the same time.

@youtalk
Copy link
Member

youtalk commented Jan 8, 2025

Oh, I'm sorry. I will be careful next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants