-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_point_types from autoware.universe #151
feat: port autoware_point_types from autoware.universe #151
Conversation
Signed-off-by: liu cui <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: liu cui <[email protected]>
Signed-off-by: liu cui <[email protected]>
Signed-off-by: liu cui <[email protected]>
Signed-off-by: liu cui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 78.75% 80.53% +1.77%
==========================================
Files 11 13 +2
Lines 193 226 +33
Branches 73 88 +15
==========================================
+ Hits 152 182 +30
Misses 11 11
- Partials 30 33 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cyn-liu Thanks for creating the package removal PR in Universe. @youtalk Thanks for the review. Just to make sure that we don't break the build for main branches (autoware-nightly.repos), let's avoid using the auto-merge and make sure that we manually merge the package porting PR in Autoware Core and package removal PR in Autoware Universe at the same time. |
Oh, I'm sorry. I will be careful next time. |
Description
Port autoware_point_types from Autoware.Universe.
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.