Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_pcl_extensions): porting from universe to core #163

Closed
wants to merge 2 commits into from

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Jan 11, 2025

Description

We are porting autoware_pcl_extensions to autoware.core, and this PR add the package to autoware.universe.

Related links

Parent Issue:

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…e_pcl_extensions, add to core repo : v0.0

Signed-off-by: liuXinGangChina <[email protected]>
Copy link

github-actions bot commented Jan 11, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 203 lines in your changes missing coverage. Please review.

Project coverage is 38.38%. Comparing base (4cb18f5) to head (edd6916).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...cl_extensions/voxel_grid_nearest_centroid_impl.hpp 0.00% 122 Missing ⚠️
...are/pcl_extensions/voxel_grid_nearest_centroid.hpp 0.00% 81 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #163       +/-   ##
===========================================
- Coverage   78.75%   38.38%   -40.38%     
===========================================
  Files          11       13        +2     
  Lines         193      396      +203     
  Branches       73      109       +36     
===========================================
  Hits          152      152               
- Misses         11      214      +203     
  Partials       30       30               
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 78.75% <ø> (ø) Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member

@YoshiRi Since we have decided to reimplement the crop_box_filter node, we won't need this package to be ported, correct?

@mitsudome-r
Copy link
Member

@liuXinGangChina Thanks for creating the PR, but I have confirmed with @YoshiRi that we can omit this package from porting target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants