Skip to content

Commit

Permalink
fix(autoware_behavior_path_goal_planner_module): remove unused functi…
Browse files Browse the repository at this point in the history
…on plot_goal_candidates()

Signed-off-by: Ryuta Kambe <[email protected]>
  • Loading branch information
veqcc committed Dec 24, 2024
1 parent d854387 commit 671a6fa
Showing 1 changed file with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,20 +135,6 @@ void plot_goal_candidate(
Kwargs("angles"_a = "xy", "scale_units"_a = "xy", "scale"_a = 2.0));
}

Check notice on line 137 in planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/examples/plot_map_case1.cpp

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Excess Number of Function Arguments

plot_goal_candidates is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
void plot_goal_candidates(
matplotlibcpp17::axes::Axes & axes, const GoalCandidates & goals,
const std::map<size_t, size_t> & goal_id2prio,
const autoware::universe_utils::LinearRing2d & local_footprint,
const std::string & color = "green")
{
for (const auto & goal : goals) {
const auto it = goal_id2prio.find(goal.id);
if (it != goal_id2prio.end()) {
plot_goal_candidate(axes, goal, it->second, local_footprint, color);
}
}
}

void plot_path_with_lane_id(
matplotlibcpp17::axes::Axes & axes, const PathWithLaneId & path,
const std::string & color = "red", const std::string & label = "", const double linewidth = 1.0)
Expand Down Expand Up @@ -607,8 +593,6 @@ int main(int argc, char ** argv)
// plot_lanelet(ax3, lanelet);
}

// plot_goal_candidates(ax1, goal_candidates, footprint);

// plot_path_with_lane_id(ax2, reference_path.path, "green", "reference_path");

const auto start = std::chrono::steady_clock::now();
Expand Down

0 comments on commit 671a6fa

Please sign in to comment.