Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_error_monitor is reporting vehicle_state_report msg timeout during planning simulation initialization #6383

Open
3 tasks done
ahmeddesokyebrahim opened this issue Feb 12, 2024 · 2 comments
Labels
component:system System design and integration. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@ahmeddesokyebrahim
Copy link
Contributor

ahmeddesokyebrahim commented Feb 12, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Part of:

Currently, we are working on a task for fixing and improving Autoware logging system as Autoware creates a noisy debugging environment, making it challenging to identify and address genuine issues.

For more details about the issue, plan how to tackle it, and linked PR, please have a look here.

For this bug, when starting planning simulator and before setting vehicle start and goal pose, system_error_monitor is reporting vehicle_state_report msg timeout as follow :

  • [system.system_error_monitor]: vehicle_state_report msg is timeout... (isDataHeartbeatTimeout() at ~/autoware/src/universe/autoware.universe/system/system_error_monitor/src/system_error_monitor_core.cpp:436)

Expected behavior

system_error_monitor is reporting vehicle_state_report msg timeout when data is actually sent then timeout occurs or after countdown during initialization

Actual behavior

system_error_monitor is directly reporting vehicle_state_report msg timeout during initialization

Steps to reproduce

  1. Open planning simulator
  2. Before setting vehicle start pose and goal pose you can see the aforementioned error message.

Versions

No response

Possible causes

No response

Additional context

@xmfcx proposed the following :
In real vehicle, this error message could be expected to be seen even when the topic is never received.

I have 2 proposals to address these:

1. System Error Monitor Init Phase

Allow system_error_monitor node to have an initial countdown (user can set the seconds) and It won't report anything for this period. After it ends, it will publish as usual.

This period can be set to something like 10s for planning simulator maybe.

2. Autoware RViz Side Panel Visualization

We could have this somehow shown as red in the future side panel for this topic.
And once this error is gone, it would turn green for this message.

(This panel issue still hasn't been created so we can skip this solution for now.)

Here is the full comment and context I am copying the proposal from for reference

@xmfcx xmfcx added component:system System design and integration. (auto-assigned) type:new-feature New functionalities or additions, feature requests. labels Feb 12, 2024
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title system_error_monitor is reporting vehicle_state_report msg timeout during initialization system_error_monitor is reporting vehicle_state_report msg timeout during planning simulation initialization Feb 29, 2024
@ahmeddesokyebrahim
Copy link
Contributor Author

@ito-san : I would highly appreciate if you can have a look and support in this issue or let us know who is the current package owner for system_error_monitor that can support here.

@xmfcx xmfcx removed this from Autoware Labs Mar 18, 2024
Copy link

stale bot commented Apr 30, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants