fix(log-messages): reduce excessive log messages

[ahmeddesokyebrahim]

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Part of:

• Reduce excessive error and warning logs on Autoware launch #5539

Related links

More details in the issue.

Relevant PRS

• autoware_launch
• autoware_common
• tier4/pointcloud_to_laserscan

Tests performed

• Planning Simulation
  • Run Autoware planning simulator and you can see no more excessive and recurring error, warning, and info message when the system running as expected
• Rosbag Replay Simulation
  • To be addressed in another PR
• AWSIM
  • To be addressed in another PR - extended goal)

Notes for reviewers

Take into consideration relevant PRs.

🔴 Merge Dependency 🔴
❗ This PR is depending on a change in autoware_common which will require the autoware_common PR to be merged firstly to have the build and test differential successful ❗

Interface changes

N.A

Effects on system behavior

• Improved console output => better developer experience specially for debugging and catching actual problems.
• Some recurrent info messages are lowered to debug level. So the developer would need to set the logger level of that specific node to see the debug message.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[xmfcx]

https://github.com/autowarefoundation/autoware.universe/actions/runs/7756002711/job/21152483741?pr=5971#step:2:23

The PR title and first commit message should start with lowercase letters.

fix(log-messages): reduce excessive log messages

You can drop "in Autoware" as well.

[xmfcx]

@ahmeddesokyebrahim can we merge this PR?

[ahmeddesokyebrahim]

https://github.com/autowarefoundation/autoware.universe/actions/runs/7756002711/job/21152483741?pr=5971#step:2:23

The PR title and first commit message should start with lowercase letters.

fix(log-messages): reduce excessive log messages

You can drop "in Autoware" as well.

@xmfcx : Thanks for the comment. This is fixed here and in other PRs as well.

[codecov]

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (a10f9c4) 14.88% compared to head (c1bce90) 14.88%.

Files	Patch %	Lines
...et2_map_loader/lanelet2_map_visualization_node.cpp	0.00%	5 Missing ⚠️
...r/src/freespace_planner/freespace_planner_node.cpp	0.00%	2 Missing and 1 partial ⚠️
.../obstacle_avoidance_planner/src/replan_checker.cpp	0.00%	3 Missing ⚠️
planning/path_smoother/src/replan_checker.cpp	0.00%	3 Missing ⚠️
...ion/crosswalk_traffic_light_estimator/src/node.cpp	0.00%	2 Missing ⚠️
...based_prediction/src/map_based_prediction_node.cpp	0.00%	2 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp	0.00%	2 Missing ⚠️
...nning_simulator/simple_planning_simulator_core.cpp	0.00%	0 Missing and 2 partials ⚠️
...ontrol/control_validator/src/control_validator.cpp	0.00%	1 Missing ⚠️
...nal_controller/src/pid_longitudinal_controller.cpp	66.66%	1 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5971      +/-   ##
==========================================
- Coverage   14.88%   14.88%   -0.01%     
==========================================
  Files        1838     1838              
  Lines      126708   126709       +1     
  Branches    38042    38044       +2     
==========================================
  Hits        18865    18865              
- Misses      86544    86545       +1     
  Partials    21299    21299              

Flag	Coverage Δ		*Carryforward flag
differential	15.93% <5.40%> (?)
total	14.89% <ø> (+<0.01%)	⬆️	Carriedforward from a10f9c4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ahmeddesokyebrahim]

@xmfcx , I see all required actions are passing now.
What is preventing this PR now from being ready for merge ?

[xmfcx]

What is preventing this PR now from being ready for merge ?

Normally, we would have to get approvals from at least 1 Code Owner from each package.

But I can override it as repo maintainer.