-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_crosswalk_traffic_light_estimator)!: tier4_debug_msgs changes to autoware_internal_debug_msgs in autoware_crosswalk_traffic_light_estimator #9870
Conversation
…es perception/autoware_crosswalk_traffic_light_estimator Signed-off-by: vish0012 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9870 +/- ##
==========================================
+ Coverage 29.18% 30.14% +0.95%
==========================================
Files 1411 1449 +38
Lines 107271 108503 +1232
Branches 42508 42493 -15
==========================================
+ Hits 31304 32703 +1399
+ Misses 72937 72598 -339
- Partials 3030 3202 +172
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mitsudome-r <[email protected]>
21d09c3
to
be45ab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me(I checked this node is not die on my local pc), but colud you please add below line in output
of README?
| `~/debug/processing_time_ms` | autoware_internal_debug_msgs::msg::Float64Stamped | pipeline latency time (ms) |
… info in README Signed-off-by: Ryohsuke Mitsudome <[email protected]>
663758a
to
1da7caa
Compare
@MasatoSaeki README is updated in 1da7caa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much.
Description
The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.
Related links
Parent Issue:
XXXStamped
messages from tier4_autoware_msgs to autoware_internal_msgs autoware#5580How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Topic changes
Modifications
~/debug/processing_time_ms
tier4_debug_msgs::msg::Float64Stamped
~/debug/processing_time_ms
autoware_internal_debug_msgs::msg::Float64Stamped
Effects on system behavior
None.