Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_crosswalk_traffic_light_estimator)!: tier4_debug_msgs changes to autoware_internal_debug_msgs in autoware_crosswalk_traffic_light_estimator #9870

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 9, 2025

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Topic changes

Modifications

Version Topic Type Topic Name Message Type Description
Old Pub ~/debug/processing_time_ms tier4_debug_msgs::msg::Float64Stamped pipeline latency time (ms)
New Pub ~/debug/processing_time_ms autoware_internal_debug_msgs::msg::Float64Stamped pipeline latency time (ms)

Effects on system behavior

None.

…es perception/autoware_crosswalk_traffic_light_estimator

Signed-off-by: vish0012 <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs changes to autoware_internal_debug_msgs in fil… feat(autoware_crosswalk_traffic_light_estimator): tier4_debug_msgs changes to autoware_internal_debug_msgs in fil… Jan 14, 2025
@mitsudome-r mitsudome-r changed the title feat(autoware_crosswalk_traffic_light_estimator): tier4_debug_msgs changes to autoware_internal_debug_msgs in fil… feat(autoware_crosswalk_traffic_light_estimator)!: tier4_debug_msgs changes to autoware_internal_debug_msgs in autoware_crosswalk_traffic_light_estimator Jan 17, 2025
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.14%. Comparing base (ce3358e) to head (1da7caa).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9870      +/-   ##
==========================================
+ Coverage   29.18%   30.14%   +0.95%     
==========================================
  Files        1411     1449      +38     
  Lines      107271   108503    +1232     
  Branches    42508    42493      -15     
==========================================
+ Hits        31304    32703    +1399     
+ Misses      72937    72598     -339     
- Partials     3030     3202     +172     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
differential-cuda 0.00% <ø> (?)
total 30.14% <ø> (+0.96%) ⬆️ Carriedforward from be45ab5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mitsudome-r <[email protected]>
@mitsudome-r mitsudome-r force-pushed the replace_debug_msgs_crosswalk_traffic_light_estimator branch from 21d09c3 to be45ab5 Compare January 21, 2025 07:01
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me(I checked this node is not die on my local pc), but colud you please add below line in output of README?

| `~/debug/processing_time_ms` | autoware_internal_debug_msgs::msg::Float64Stamped | pipeline latency time (ms) |

@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jan 22, 2025
@mitsudome-r mitsudome-r force-pushed the replace_debug_msgs_crosswalk_traffic_light_estimator branch from 663758a to 1da7caa Compare January 22, 2025 08:39
@mitsudome-r
Copy link
Member

mitsudome-r commented Jan 22, 2025

@MasatoSaeki README is updated in 1da7caa

Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you so much.

@mitsudome-r mitsudome-r enabled auto-merge (squash) January 22, 2025 08:59
@mitsudome-r mitsudome-r merged commit 58d303c into autowarefoundation:main Jan 22, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants