-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(goal_planner): remove enable_safety_check because it is default #10052
refactor(goal_planner): remove enable_safety_check because it is default #10052
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
8dcce5d
to
4869384
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
8e9e526
to
cd59bbb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10052 +/- ##
==========================================
- Coverage 28.32% 28.31% -0.01%
==========================================
Files 1485 1488 +3
Lines 111103 111142 +39
Branches 43171 43158 -13
==========================================
Hits 31468 31468
- Misses 76614 76652 +38
- Partials 3021 3022 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ult (autowarefoundation#10052) Signed-off-by: Mamoru Sobue <[email protected]>
Description
goal_planner never works without PredictedObject, so enable_safety_check is treated as true.
depends #10050
Related links
Parent Issue:
How was this PR tested?
Psim works
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.