feat(map_loader): show intersection areas #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
requested review from
kminoda,
Motsu-san,
mitsudome-r and
RyuYamamoto
as code owners
github-actions
bot
added
the
component:map
Merged
4 tasks
|
@satoshi-ota Thank you for your PR! Could you tell us who you want to review this? |
@Motsu-san Thanks! Yes, I would like you to review this PR. (On the other hand, I asked @mitsudome-r san to review this in slack.) |
|
@satoshi-ota The following PR is related isn't it? |
@Motsu-san YES! I'll add link to PR description. |
satoshi-ota
added
the
run:build-and-test-differential
|
Sorry for my confusing LGTM post, I will approve this after all checks are passed. |
mitsudome-r
approved these changes
Oct 25, 2023
|
FYI, I have merged the dependent PR in autoware_common. |
|
Conflict... 🥺 I'll fix it. |
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/show-intersection-area
branch
from
dce9649 to
8a3829c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show intersection area polygon.
related PR:
Tests performed
Psim.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.