Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): update azimuth and distance in distortion_correction_node #5560

Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
08d9e45
distortion node is able to update azimuth and distance value based on…
vividf Nov 13, 2023
404e59a
wrong opencv head file
vividf Nov 13, 2023
6a1c6da
update the distortion node docs
vividf Nov 13, 2023
c99dbb7
update the distortion node docs
vividf Nov 13, 2023
598bd42
fix if else condition to update value even in sensor frame
vividf Nov 13, 2023
447a71d
update readme for distortion node
vividf Nov 13, 2023
ab81c47
style(pre-commit): autofix
pre-commit-ci[bot] Nov 13, 2023
1ed9e29
Update distortion-corrector.md
vividf Nov 14, 2023
8502d89
remove parameter default value
vividf Nov 14, 2023
2058788
remove get_parameter
vividf Nov 14, 2023
dffbd56
style(pre-commit): autofix
pre-commit-ci[bot] Nov 14, 2023
d779a36
Update distortion-corrector.md
vividf Nov 15, 2023
e2b9526
style(pre-commit): autofix
pre-commit-ci[bot] Nov 15, 2023
78dde17
Update distortion-corrector.md
vividf Nov 15, 2023
ef03a19
style(pre-commit): autofix
pre-commit-ci[bot] Nov 15, 2023
4929958
Update distortion-corrector.md
vividf Nov 15, 2023
a7ccf4a
Merge branch 'autowarefoundation:main' into feat/distortion_correctio…
vividf Nov 16, 2023
686ec6a
Merge branch 'autowarefoundation:main' into feat/distortion_correctio…
vividf Nov 16, 2023
7b51d4f
Merge branch 'autowarefoundation:main' into feat/distortion_correctio…
vividf Mar 4, 2024
192a89d
Merge branch 'autowarefoundation:main' into feat/distortion_correctio…
vividf Mar 7, 2024
fb2ab65
Merge branch 'autowarefoundation:main' into feat/distortion_correctio…
vividf Mar 12, 2024
55682dd
modify ring outlier filter node for supporting counter clockwise azimuth
vividf Mar 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update distortion-corrector.md
vividf authored Nov 15, 2023
commit 49299583c72c7d6dc5a5ae507e0bae9a2d86b401
4 changes: 2 additions & 2 deletions sensing/pointcloud_preprocessor/docs/distortion-corrector.md
Original file line number Diff line number Diff line change
@@ -47,10 +47,10 @@ $ ExactPointTime = TimeStamp + TimeOffset $

## Assumptions / Known limits

When setting the parameter `update_azimuth_and_distance` to `true`, the node will calculate the per-point azimuth and distance values based on the undistorted XYZ using the cv:fastAtan2 function. The azimuth value will have its origin along the x-axis. Please make sure the frame coordinates are the same as the coordinate system mentioned above. For Autoware users, the `frame_id` of the input pointcloud is `base_link`, in which the coordinate system is the same as the coordinate system mentioned above, therefore it will not cause any issues.
When setting the parameter `update_azimuth_and_distance` to `true`, the node will calculate the per-point azimuth and distance values based on the undistorted XYZ using the `cv:fastAtan2` function. The azimuth value will have its origin along the x-axis. Please make sure the frame coordinates are the same as the coordinate system mentioned above. For Autoware users, the `frame_id` of the input pointcloud is `base_link`, in which the coordinate system is the same as the coordinate system mentioned above, therefore it will not cause any issues.

Please note that by setting the parameter `update_azimuth_and_distance` to `true`, the time will increase by around 13%.
Also note that due to the cv::fastAtan2 algorithm (accuracy is about 0.3 degrees), there is the **possibility of changing beam order for high azimuth resolution LiDAR**.
Also note that due to the `cv::fastAtan2` algorithm (accuracy is about 0.3 degrees), there is the **possibility of changing beam order for high azimuth resolution LiDAR**.

## References/External links