Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probabilistic_occupancy_grid_map): add grid map fusion node #5993

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 28, 2023

Description

This PR is part of the multi-lidar based grid map fusion.
Original PR: #5485

This PR adds node to fuse two synchronized(same timestamp) occupancy grid map message.

Detailed features

    1. add synchronized_grid_map_fusion node
    • synchronized grid map fusion node enables to gather multiple ogm messages and fuse it
    • Process are shown in below
    • Its settings are defined in config/synchronized_grid_map_fusion_node.param.yaml

image

    1. add test
    • this PR also adds new tests to evaluate some uitil functions and launch test to check node behavior

Related links

Tests performed

Tested with gtest, launch test and Lsim.
See TIER IV internal ticket.

Other information in conflu.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 28, 2023
@YoshiRi YoshiRi marked this pull request as ready for review December 28, 2023 07:34
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 249 lines in your changes are missing coverage. Please review.

Comparison is base (705a70d) 15.30% compared to head (2426d8f) 15.36%.
Report is 117 commits behind head on main.

Files Patch % Lines
...p/src/fusion/synchronized_grid_map_fusion_node.cpp 27.18% 54 Missing and 96 partials ⚠️
...grid_map/src/fusion/single_frame_fusion_policy.cpp 44.00% 48 Missing and 8 partials ⚠️
...tic_occupancy_grid_map/test/fusion_policy_test.cpp 31.25% 0 Missing and 22 partials ⚠️
...listic_occupancy_grid_map/test/cost_value_test.cpp 37.50% 0 Missing and 10 partials ⚠️
...bilistic_occupancy_grid_map/include/cost_value.hpp 60.00% 2 Missing and 2 partials ⚠️
...obabilistic_occupancy_grid_map/src/utils/utils.cpp 0.00% 4 Missing ⚠️
...cupancy_grid_map_log_odds_bayes_filter_updater.cpp 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5993      +/-   ##
==========================================
+ Coverage   15.30%   15.36%   +0.06%     
==========================================
  Files        1740     1747       +7     
  Lines      119914   120297     +383     
  Branches    36450    36669     +219     
==========================================
+ Hits        18351    18484     +133     
- Misses      81028    81138     +110     
- Partials    20535    20675     +140     
Flag Coverage Δ *Carryforward flag
differential 27.56% <35.15%> (?)
total 15.30% <ø> (-0.01%) ⬇️ Carriedforward from 705a70d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 4a419f8 into autowarefoundation:main Jan 9, 2024
28 of 34 checks passed
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…owarefoundation#5993)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* chore: remove files outof scope with divied PR

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…owarefoundation#5993)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* chore: remove files outof scope with divied PR

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…owarefoundation#5993)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* chore: remove files outof scope with divied PR

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…owarefoundation#5993)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* chore: remove files outof scope with divied PR

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants