Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): cut predicted paths after red lights #6478

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Feb 22, 2024

Description

To avoid incorrect stops with the out_of_lane module, the predicted paths of dynamic objects can now be cut beyond the stop line of a red traffic light.

Required launch PR: autowarefoundation/autoware_launch#885

Tests performed

(TIER IV INTERNAL LINKS)

Can also be tested with Psim and the traffic light panel.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 22, 2024
@maxime-clem maxime-clem changed the title Fix/out of lane cut pred paths after red light feat(out_of_lane): cut predicted paths after red lights Feb 22, 2024
@maxime-clem maxime-clem force-pushed the fix/out_of_lane-cut-pred-paths-after-red-light branch from 863fb36 to a9d2fa1 Compare February 22, 2024 07:04
@maxime-clem maxime-clem force-pushed the fix/out_of_lane-cut-pred-paths-after-red-light branch from a9d2fa1 to 6bca95b Compare March 1, 2024 05:35
TODO: check perf, take object footprint size into account when cutting,
add param

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem force-pushed the fix/out_of_lane-cut-pred-paths-after-red-light branch from 6bca95b to 5d12185 Compare March 4, 2024 04:11
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
@maxime-clem maxime-clem marked this pull request as ready for review March 4, 2024 04:22
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 2.73973% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (44e4be7) to head (5d12185).
Report is 4 commits behind head on main.

Files Patch % Lines
...ut_of_lane_module/src/filter_predicted_objects.cpp 3.44% 55 Missing and 1 partial ⚠️
...vior_velocity_out_of_lane_module/src/decisions.cpp 0.00% 8 Missing ⚠️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 0.00% 1 Missing and 4 partials ⚠️
...havior_velocity_out_of_lane_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6478      +/-   ##
==========================================
- Coverage   14.79%   14.78%   -0.01%     
==========================================
  Files        1917     1918       +1     
  Lines      132001   132052      +51     
  Branches    39228    39254      +26     
==========================================
+ Hits        19524    19525       +1     
- Misses      90688    90733      +45     
- Partials    21789    21794       +5     
Flag Coverage Δ *Carryforward flag
differential 21.34% <2.73%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 44e4be7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const auto traffic_signal_stamped = planner_data.getTrafficSignal(element->id());
if (
traffic_signal_stamped.has_value() && element->stopLine().has_value() &&
traffic_light_utils::isTrafficSignalStop(ll, traffic_signal_stamped.value().signal)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we turn left, and the traffic signal for the vehicle coming from the left is unknown, which is actually green, the out_of_lane module ignores the vehicle as not expected.

Am I understanding correct? I think it's okay for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your understanding is correct and I will think about what should be the behavior in the UNKNOWN traffic light case.

@maxime-clem maxime-clem merged commit f9dd38c into autowarefoundation:main Mar 8, 2024
35 of 38 checks passed
@maxime-clem maxime-clem deleted the fix/out_of_lane-cut-pred-paths-after-red-light branch March 8, 2024 00:14
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Apr 8, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants