-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(out_of_lane): cut predicted paths after red lights #6478
feat(out_of_lane): cut predicted paths after red lights #6478
Conversation
863fb36
to
a9d2fa1
Compare
a9d2fa1
to
6bca95b
Compare
TODO: check perf, take object footprint size into account when cutting, add param Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
6bca95b
to
5d12185
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
- Coverage 14.79% 14.78% -0.01%
==========================================
Files 1917 1918 +1
Lines 132001 132052 +51
Branches 39228 39254 +26
==========================================
+ Hits 19524 19525 +1
- Misses 90688 90733 +45
- Partials 21789 21794 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
const auto traffic_signal_stamped = planner_data.getTrafficSignal(element->id()); | ||
if ( | ||
traffic_signal_stamped.has_value() && element->stopLine().has_value() && | ||
traffic_light_utils::isTrafficSignalStop(ll, traffic_signal_stamped.value().signal)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we turn left, and the traffic signal for the vehicle coming from the left is unknown, which is actually green, the out_of_lane module ignores the vehicle as not expected.
Am I understanding correct? I think it's okay for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your understanding is correct and I will think about what should be the behavior in the UNKNOWN
traffic light case.
Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…dation#6478) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…dation#6478) Signed-off-by: Maxime CLEMENT <[email protected]>
…dation#6478) Signed-off-by: Maxime CLEMENT <[email protected]>
Description
To avoid incorrect stops with the
out_of_lane
module, the predicted paths of dynamic objects can now be cut beyond the stop line of a red traffic light.Required launch PR: autowarefoundation/autoware_launch#885
Tests performed
(TIER IV INTERNAL LINKS)
Can also be tested with Psim and the traffic light panel.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.