fix(mission_planner): find the first common interval naively for main/mrm reroute check #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
soblin
requested review from
isamu-takagi,
kosuke55,
mitsudome-r,
TakaHoribe and
takayuki5168
as code owners
soblin
force-pushed
the
fix/mission_planner/reroute-safety-check
branch
from
84d7736 to
06eb3d3
Compare
…/mrm reroute check Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
fix/mission_planner/reroute-safety-check
branch
from
06eb3d3 to
bee9936
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6504 +/- ##
==========================================
- Coverage 14.64% 14.64% -0.01%
==========================================
Files 1899 1899
Lines 130282 130303 +21
Branches 38311 38311
==========================================
Hits 19083 19083
- Misses 89784 89805 +21
Partials 21415 21415
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 29, 2024
…/mrm reroute check (autowarefoundation#6504) Signed-off-by: Mamoru Sobue <[email protected]>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…/mrm reroute check (#6504) Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…/mrm reroute check (autowarefoundation#6504) Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: kaigohirao <[email protected]>
mkuri
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 4, 2024
fix(mission_planner): find the first common interval naively for main/mrm reroute check (autowarefoundation#6504)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…/mrm reroute check (autowarefoundation#6504) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the rerouting happened between main/mrm, the safety check logic tries to find the common interval between the two. the previous logic worked only when the common interval beginning matches the beginning of either route.
So if the common interval is in the middle of each route, it fails to find "100 200 300" as shown in below.
In this PR the beginning of common interval is obtained in naive way.
Related links
https://tier4.atlassian.net/browse/RT1-5332
Tests performed
RT1-5332-2024-02-28_13.46.44.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.