fix(mrm_handler): fix bug in operation mode availability timeout #6513
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::getCurrentMrmBehavior
- Complex Method mrm_handler_core.cpp: MrmHandler::getCurrentMrmBehavior
Annotations
Check warning on line 545 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
MrmHandler::getCurrentMrmBehavior increases in cyclomatic complexity from 25 to 29, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 545 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Bumpy Road Ahead
MrmHandler::getCurrentMrmBehavior increases from 7 to 11 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.77 to 4.83, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.