-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mrm_handler, emergency_handler): remove takeover #6522
Conversation
Signed-off-by: veqcc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6522 +/- ##
==========================================
+ Coverage 14.78% 14.81% +0.03%
==========================================
Files 1917 1917
Lines 132038 131746 -292
Branches 39228 39187 -41
==========================================
Hits 19523 19523
+ Misses 90726 90441 -285
+ Partials 21789 21782 -7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update(mrm_handler, emergency_handler): remove takeover Signed-off-by: veqcc <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…tion#6522) update(mrm_handler, emergency_handler): remove takeover Signed-off-by: veqcc <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…tion#6522) update(mrm_handler, emergency_handler): remove takeover Signed-off-by: veqcc <[email protected]>
…tion#6522) update(mrm_handler, emergency_handler): remove takeover Signed-off-by: veqcc <[email protected]>
Description
Remove
takeover
functions.See #2994 for more detail.
Tests performed
Confirmed MRM changes from (NORMAL, NODE) to (OPERATING, EMERGENCY_STOP) in Psim.
Confirmed MRM changes from (OPERATING, EMERGENCY_STOP) to (NORMAL, NODE) in Psim.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.