fix(ci): remove json-schema-check filter #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <[email protected]>
github-actions
bot
added
the
type:ci
HansRobo
added
the
run:build-and-test-differential
7 tasks
xmfcx
approved these changes
Mar 1, 2024
|
Thank you @HansRobo for the quick fix, sorry for overlooking this possibility. It is such a low cost check, I think it's alright if it runs for every PR for now. In future we can add some sort of check to make it pass successfully automatically if certain files are unchanged. (low priority) |
4 tasks
HansRobo
added a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]> Signed-off-by: kaigohirao <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
json-schema-checkworkflow is required for merging pull-request now.But
json-schema-checkfires only when you edited parameter files or schema files.So,
json-schema-checkblocks merging pull-requests without parameter files or schema files changes.This is a naive solution, and there may be a more elegant method, but I will suggest it for now.
Related: #6473
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.