feat(map_loader): add waypoints flag #7480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
takayuki5168
changed the title
takayuki5168
requested review from
kosuke55,
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
takayuki5168
added
the
run:build-and-test-differential
4 tasks
SakodaShintaro
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
I have confirmed that logging_simulator works properly with merging the three pull requests.
As far as I can review, there doesn't seem to be a problem, but I'm not very familiar with these codes, so if you need a detailed review, please wait for someone else to approve it.
|
@takayuki5168 Cloud you please add |
YamatoAndo
removed
the
run:build-and-test-differential
|
@SakodaShintaro @YamatoAndo |
kosuke55
approved these changes
Jun 16, 2024
takayuki5168
added
the
run:build-and-test-differential
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/use-waypoints-in-map-loader
branch
from
1f908fa to
0378197
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/use-waypoints-in-map-loader
branch
from
0378197 to
2e5a204
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
removed
the
component:common
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7480 +/- ##
==========================================
- Coverage 14.84% 7.48% -7.37%
==========================================
Files 1999 435 -1564
Lines 139163 36201 -102962
Branches 43716 5526 -38190
==========================================
- Hits 20661 2708 -17953
+ Misses 95731 33194 -62537
+ Partials 22771 299 -22472
☔ View full report in Codecov by Sentry. |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
* feat(map_loader): handle centelrine and waypoints Signed-off-by: Takayuki Murooka <[email protected]> * update README Signed-off-by: Takayuki Murooka <[email protected]> * fix doc Signed-off-by: Takayuki Murooka <[email protected]> * update schema Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat(map_loader): handle centelrine and waypoints Signed-off-by: Takayuki Murooka <[email protected]> * update README Signed-off-by: Takayuki Murooka <[email protected]> * fix doc Signed-off-by: Takayuki Murooka <[email protected]> * update schema Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change by autowarefoundation/autoware_common#252
In the above PR,
use_waypointsis defined and this PR uses it. Please see the above PR in detail.Tests performed
simple planning simulator works.
Effects on system behavior
The centerline is treated as waypoints inside the Autoware's implementation.
As a result, the centerline will be connected to the planned path smoothly, and fix several limitations described here
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.