Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): put back subscriber rather than using polling subsriber #7500

Merged
merged 3 commits into from
Jun 17, 2024

Merge branch 'main' into fix/vehicle_cmd_gate_subscriber

34161f8
Select commit
Loading
Failed to load commit list.
Merged

fix(vehicle_cmd_gate): put back subscriber rather than using polling subsriber #7500

Merge branch 'main' into fix/vehicle_cmd_gate_subscriber
34161f8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 17, 2024 in 43s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method vehicle_cmd_gate.cpp: VehicleCmdGate::VehicleCmdGate

✅ Improving Code Health:

  • Complex Method vehicle_cmd_gate.cpp: VehicleCmdGate::onTimer

Annotations

Check notice on line 386 in control/autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method 

VehicleCmdGate::onTimer decreases in cyclomatic complexity from 26 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 120 in control/autoware_vehicle_cmd_gate/src/vehicle_cmd_gate.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

VehicleCmdGate::VehicleCmdGate increases from 113 to 138 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis