Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surround_obstacle_checker): remove include directory #7507

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 17, 2024

Description

Since the autoware_surround_obstacle_checker is not a library, include directory is removed in this PR.

Tests performed

Unit test

Effects on system behavior

Nothing

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 17, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review June 17, 2024 07:35
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 17, 2024
@takayuki5168 takayuki5168 merged commit 50b7659 into autowarefoundation:main Jun 17, 2024
35 checks passed
@takayuki5168 takayuki5168 deleted the feat/surround-obstacle-without-include branch June 17, 2024 08:12
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…undation#7507)

* feat(surround_obstacle_checker): remove include directory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat(surround_obstacle_checker): remove include directory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants