refactor(lane_change): use lane change namespace for structs #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7508 +/- ##
===========================================
- Coverage 14.84% 10.73% -4.11%
===========================================
Files 1999 259 -1740
Lines 139163 26486 -112677
Branches 43716 4634 -39082
===========================================
- Hits 20661 2844 -17817
+ Misses 95731 23280 -72451
+ Partials 22771 362 -22409
☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
force-pushed
the
lane-change-data-structs-namespace
branch
from
4827a6d to
47f8e99
Compare
zulfaqar-azmi-t4
requested review from
go-sakayori,
kyoichi-sugahara,
TakaHoribe and
takayuki5168
as code owners
rej55
approved these changes
Jun 19, 2024
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
lane-change-data-structs-namespace
branch
from
47f8e99 to
a97ff15
Compare
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…efoundation#7508) * refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 1, 2024
…efoundation#7508) * refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 6, 2024
…efoundation#7508) * refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2024
…efoundation#7508) * refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Aug 15, 2024
…efoundation#7508) * refactor(lane_change): use lane change namespace for structs Signed-off-by: Zulfaqar Azmi <[email protected]> * Move lane change namespace to bottom level Signed-off-by: Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move a few structs to
lane_changenamespace.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.