-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yabloc_monitor): componentize yabloc_monitor node #7509
feat(yabloc_monitor): componentize yabloc_monitor node #7509
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7509 +/- ##
==========================================
- Coverage 14.84% 14.84% -0.01%
==========================================
Files 1999 1999
Lines 139163 139130 -33
Branches 43716 43699 -17
==========================================
- Hits 20661 20647 -14
Misses 95731 95731
+ Partials 22771 22752 -19
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that yabloc works fine in your rosbag data with rqt_runtime_monitor, and the glog appears when the yabloc_monitor it is terminated.
LGTM 👍
…ation#7509) * change node to component Signed-off-by: Kento Yabuuchi <[email protected]> * fix launch file & cmake Signed-off-by: Kento Yabuuchi <[email protected]> --------- Signed-off-by: Kento Yabuuchi <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
* change node to component Signed-off-by: Kento Yabuuchi <[email protected]> * fix launch file & cmake Signed-off-by: Kento Yabuuchi <[email protected]> --------- Signed-off-by: Kento Yabuuchi <[email protected]>
Description
Componentize the node in localization/yabloc_monitor.
Also, log output is changed from "screen" to "both".
Tests performed
1. Confirmed that yabloc works as conventional in logging_simulator
If yabloc_monitor is running correctly, we can see the following diagnostics in rqt_runtime_monitor.
2. Confirmed that terminating the nodes process will output logs to both the terminal and the launch.log.
( The glog is printed only when using rclcpp_component customized by tier4. )
Effects on system behavior
The system behavior does not change.
Interface changes
The interface does not change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.