Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(clang-tidy): test if workflow fails only when it reports errors #7749

Closed
wants to merge 5 commits into from
+3 −1
Closed

test(clang-tidy): test if workflow fails only when it reports errors #7749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6476d8
test(clang-tidy): test if workflow fails only when it reports errors
Jun 28, 2024
b25cf26
add dummy change
Jun 28, 2024
93f102f
test for success
Jun 28, 2024
3474eed
a
Jun 28, 2024
fa2be66
test: clang-tidy differential will fail
veqcc Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a 
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
M. Fatih Cırıt committed Jun 28, 2024
commit 3474eed3ac120e6d64a2892a51aa8dd1ae7c93c0
2 changes: 2 additions & 0 deletions map/map_loader/test/test_pointcloud_map_loader_module.cpp
View file
Original file line number Diff line number Diff line change
@@ -26,6 +26,8 @@
#include <chrono>
#include <memory>

// TODO(mfc): remove this comment line.

using std::chrono_literals::operator""ms;

class TestPointcloudMapLoaderModule : public ::testing::Test
2 changes: 0 additions & 2 deletions sensing/gnss_poser/src/gnss_poser_core.cpp
View file
Original file line number Diff line number Diff line change
@@ -24,8 +24,6 @@
#include <string>
#include <vector>

// TODO(mfc): remove this comment line please. a

namespace gnss_poser
{
GNSSPoser::GNSSPoser(const rclcpp::NodeOptions & node_options)

Unchanged files with check annotations Beta

View file
.github/workflows/build-and-test-differential.yaml
- name: Export CUDA state as a variable for adding to cache key
run: |
build_type_cuda_state=nocuda

Check warning on line 79 in .github/workflows/build-and-test-differential.yaml

GitHub Actions / spell-check-differential 

Unknown word (nocuda)
if [[ "${{ matrix.container-suffix }}" == "-cuda" ]]; then
build_type_cuda_state=cuda
fi