refactor(velocity_smoother): change method to take data for external velocity #7810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <[email protected]>
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
requested review from
rej55,
mkuri,
satoshi-ota and
TakaHoribe
as code owners
rej55
approved these changes
Jul 4, 2024
go-sakayori
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7810 +/- ##
==========================================
- Coverage 28.55% 28.54% -0.02%
==========================================
Files 1586 1590 +4
Lines 115879 115927 +48
Branches 49384 49384
==========================================
+ Hits 33093 33094 +1
- Misses 73823 73871 +48
+ Partials 8963 8962 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…velocity (autowarefoundation#7810) refactor external velocity Signed-off-by: Go Sakayori <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…velocity (autowarefoundation#7810) refactor external velocity Signed-off-by: Go Sakayori <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…velocity (#7810) refactor external velocity Signed-off-by: Go Sakayori <[email protected]>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…velocity (autowarefoundation#7810) refactor external velocity Signed-off-by: Go Sakayori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before using the polling subscriber the member variable
external_velocity_limit_ptr_was set tonullptronce it was used. However by usingtakeData()the latest msg would be used continuously. This PR solves the problem by utilizingtakeNewData()instead oftakeData().Related links
None
How was this PR tested?
TIER IV internal simulator
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.