Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(evalautor): rename evaluator diag topics #8152

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat(evalautor): rename evaluator diag topics #8152

merged 2 commits into from
Jul 29, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 23, 2024 •
edited
Loading

Description

/diagnostic/* topic name is confusing because theare are /diagnostics/* topics.
and in the future, we plan to separate metrics (just calculate value) and diagnostics (compare with threshould).

image

Related links

Parent Issue:

  • Link

Private Links:

How was this PR tested?

2024/07/23 https://evaluation.tier4.jp/evaluation/reports/fda048c3-d0c1-549c-91e6-9a7444741bb8/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jul 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
takayuki5168
takayuki5168 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kosuke55
Copy link
Contributor Author

@kyoichi-sugahara @maxime-clem
please check as a code owner.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.12%. Comparing base (c3bf28c) to head (8539049).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8152      +/-   ##
==========================================
- Coverage   29.13%   29.12%   -0.01%     
==========================================
  Files        1609     1611       +2     
  Lines      118147   118176      +29     
  Branches    50850    50853       +3     
==========================================
+ Hits        34420    34424       +4     
- Misses      74480    74506      +26     
+ Partials     9247     9246       -1
Flag Coverage Δ *Carryforward flag
differential 12.77% <ø> (?)
total 29.13% <ø> (ø) Carriedforward from 355c48e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara
Copy link
Contributor

@kosuke55
This PR's change looks good to me, but the other implementation which refers to this topic like here also should be changed together?

And /diagnostic/perception_online_evaluator/* will be kept as it is? Or this is out of to topic for now?

@kyoichi-sugahara kyoichi-sugahara self-assigned this Jul 23, 2024
@kosuke55
perception
8539049 
Signed-off-by: kosuke55 <[email protected]>
This was referenced Jul 23, 2024
Merged
Merged
@hayato-m126 hayato-m126 mentioned this pull request Jul 23, 2024
Closed
1 task
@kosuke55 kosuke55 mentioned this pull request Jul 23, 2024
Merged
@kosuke55
Copy link
Contributor Author

@kyoichi-sugahara
thanks!
fixed in
autowarefoundation/autoware_tools#82

@kosuke55 kosuke55 merged commit 4a92ae6 into autowarefoundation:main Jul 29, 2024
29 of 30 checks passed
@kosuke55 kosuke55 deleted the feat/rename_evaluator_topics branch July 29, 2024 04:07
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jul 30, 2024
@kosuke55 @shmpwk
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
0ef54a4 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
@shmpwk shmpwk mentioned this pull request Jul 30, 2024
Merged
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Jul 30, 2024
@shmpwk @kosuke55
feat(evalautor): rename evaluator diag topics (#1432)
622d6e3 
* feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)

* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>

* fix: adapt v0.29.0 control launcher

Signed-off-by: Shumpei Wakabayashi <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Jul 31, 2024
@kosuke55 @danielsanchezaran
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
68c26a5 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
hayato-m126 added a commit to tier4/driving_log_replayer_v2 that referenced this pull request Jul 31, 2024
@hayato-m126
feat: update topic name
f87670d 
autowarefoundation/autoware.universe#8152
hayato-m126 added a commit to tier4/driving_log_replayer_v2 that referenced this pull request Aug 2, 2024
@hayato-m126
feat: planning control evaluator (#2)
04f4081 
* feat: planning control node

* feat: update evaluation logic

* feat: update evaluation logic

* fix: cast string

* fix: field

* feat: add unit test

* chore: add temporary logic

* fix: lane condition

* fix: lane s condition

* chore: allow empty KinematicCondition

* chore: add output decision

* chore: update sample

* chore: pre-commit

* feat: add remap /localization/acceleration

* docs: update

* docs: update can msg

* feat: support LaunchPerception and LaunchPlanning

* feat: remap topic in bag

* fix: pre-commit

* chore: update status length check

* fix: remap

* docs: update document

* docs: update sample

* feat: update unit test

* fix: local variable lane_info_tuple referenced before assignment

* feat: update scenario format and enable/disable component

* feat: update topic name

autowarefoundation/autoware.universe#8152

* fix: pre-commit
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@kosuke55 @esteve
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
85df932 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2024
@kosuke55 @danielsanchezaran
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
1f5377b 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
@kosuke55 @danielsanchezaran
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
76c39e3 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
@kosuke55 @danielsanchezaran
feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)
92ca5f9 
* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <[email protected]>

* perception

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
@danielsanchezaran danielsanchezaran mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@xtk8532704 xtk8532704 xtk8532704 approved these changes

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@miursh miursh Awaiting requested review from miursh

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

Assignees

@xtk8532704 xtk8532704

@kyoichi-sugahara kyoichi-sugahara

Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kosuke55 @kyoichi-sugahara @takayuki5168 @xtk8532704 @maxime-clem