refactor(test_utils): return parser as optional #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
mkquda,
rej55,
kosuke55,
maxime-clem,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
go-sakayori,
soblin,
takayuki5168,
kyoichi-sugahara and
TakaHoribe
as code owners
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
reviewed
Nov 20, 2024
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9391 +/- ##
=======================================
Coverage 29.49% 29.50%
=======================================
Files 1439 1443 +4
Lines 108495 108540 +45
Branches 41479 41483 +4
=======================================
+ Hits 32005 32026 +21
- Misses 73380 73401 +21
- Partials 3110 3113 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
force-pushed
the
refactor-test-utils-optional
branch
from
64e5ef4 to
57f015b
Compare
soblin
approved these changes
Nov 22, 2024
zulfaqar-azmi-t4
force-pushed
the
refactor-test-utils-optional
branch
from
a8b2547 to
ab98044
Compare
|
@mkquda Can you approve this PR ? |
zulfaqar-azmi-t4
force-pushed
the
refactor-test-utils-optional
branch
from
ab98044 to
2285342
Compare
mkquda
reviewed
Nov 27, 2024
mkquda
reviewed
Nov 27, 2024
mkquda
reviewed
Nov 27, 2024
...avior_path_planner/autoware_behavior_path_lane_change_module/test/test_lane_change_scene.cpp
Outdated
Show resolved
Hide resolved
zulfaqar-azmi-t4
force-pushed
the
refactor-test-utils-optional
branch
from
2285342 to
c421b07
Compare
github-actions
bot
added
the
type:ci
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
refactor-test-utils-optional
branch
from
f73aede to
e3c74c5
Compare
github-actions
bot
removed
the
type:ci
mkquda
approved these changes
Nov 28, 2024
kyoichi-sugahara
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible the the parser function is being used incorrectly, which will return in correct results.
This PR refactor the function to return optional instead.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.