-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_ground_segmentation): fix clang-diagnostic-inconsistent-missing-override #9517
Conversation
Signed-off-by: kobayu858 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9517 +/- ##
==========================================
- Coverage 29.51% 29.51% -0.01%
==========================================
Files 1440 1439 -1
Lines 108541 108546 +5
Branches 41507 41509 +2
==========================================
- Hits 32034 32033 -1
- Misses 73388 73393 +5
- Partials 3119 3120 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perception/autoware_ground_segmentation/src/scan_ground_filter/node.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kobayu858 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kobayu858 !
@amc-nu @badai-nguyen @miursh @YoshiRi @yukkysaito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a fix based on clang-tidy
clang-diagnostic-inconsistent-missing-override
error.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.