Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_ground_segmentation): fix clang-diagnostic-inconsistent-missing-override #9517

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-inconsistent-missing-override error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_ground_segmentation/src/scan_ground_filter/node.hpp:159:16: error: 'faster_filter' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
  virtual void faster_filter(
               ^
/home/emb4/autoware/autoware/install/autoware_pointcloud_preprocessor/include/autoware_pointcloud_preprocessor/autoware/pointcloud_preprocessor/filter.hpp:194:16: note: overridden virtual function is here
  virtual void faster_filter(
               ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2024
@kobayu858 kobayu858 requested a review from veqcc November 28, 2024 09:05
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.51%. Comparing base (4e93960) to head (e7d10b5).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9517      +/-   ##
==========================================
- Coverage   29.51%   29.51%   -0.01%     
==========================================
  Files        1440     1439       -1     
  Lines      108541   108546       +5     
  Branches    41507    41509       +2     
==========================================
- Hits        32034    32033       -1     
- Misses      73388    73393       +5     
- Partials     3119     3120       +1     
Flag Coverage Δ *Carryforward flag
differential 13.86% <ø> (?)
total 29.51% <ø> (ø) Carriedforward from 8a22503

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kobayu858 <[email protected]>
@xmfcx
Copy link
Contributor

xmfcx commented Nov 28, 2024

image

image

I'm trying to see which one will work in this PR.

Related discussion:

image
It didn't work again :( I am adding it wrong to the required status checks, trying to figure it out.

cc. @yhisaki @veqcc

@xmfcx
Copy link
Contributor

xmfcx commented Nov 28, 2024

image

image

With just clang-tidy-differential it worked! @yhisaki @veqcc

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kobayu858 !

@kobayu858
Copy link
Contributor Author

@amc-nu @badai-nguyen @miursh @YoshiRi @yukkysaito
Please confirm the PR. Thank you very much.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit df241f7 into autowarefoundation:main Dec 2, 2024
30 of 32 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-pe59 branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants