fix(autoware_image_projection_based_fusion): detected object roi box projection fix #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
force-pushed
the
fix/image-proj-fus/roi-range-fix
branch
from
fe461df to
3d9f51c
Compare
technolojin
requested review from
yukkysaito,
badai-nguyen,
tzhong518 and
YoshiRi
yukkysaito
reviewed
Dec 2, 2024
perception/autoware_image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp
Show resolved
Hide resolved
1. eliminate misuse of std::numeric_limits<double>::min() 2. fix roi range up to the image edges Signed-off-by: Taekjin LEE <[email protected]>
Improve the calculation of the region of interest (ROI) in the RoiDetectedObjectFusionNode. The previous code had an issue where the ROI range was not correctly limited to the image edges. This fix ensures that the ROI is within the image boundaries by using the correct comparison operators for the x and y coordinates. Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
fix/image-proj-fus/roi-range-fix
branch
from
3d9f51c to
26cdeea
Compare
technolojin
requested review from
kminoda,
ktro2828 and
miursh
as code owners
technolojin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9519 +/- ##
==========================================
- Coverage 29.49% 29.49% -0.01%
==========================================
Files 1443 1444 +1
Lines 108648 108659 +11
Branches 41537 41538 +1
==========================================
+ Hits 32047 32048 +1
- Misses 73479 73489 +10
Partials 3122 3122
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
std::numeric_limits<double>::min()Related links
Parent Issue:
How was this PR tested?
Objects at the edges are fused without issue.
Notes for reviewers
It will be merged after #9505 is merged and the build issue is resolved.
Interface changes
None.
Effects on system behavior
None.