Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): move PathDecisionController implementation to a different file #9523

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 29, 2024

Description

depends #9522, see the diff here: tier4/autoware.universe@tier4:autoware.universe:refactor/goal-planner/move-unnecessary-memfn...tier4:autoware.universe:refactor/goal-planner/move-decision-state

for achieving #9514

move PathDecisionController implementation to a different file

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin changed the title Refactor/goal planner/move decision state refactor(goal_planner): move PathDecisionController implementation to a different file Nov 29, 2024
@soblin soblin force-pushed the refactor/goal-planner/move-decision-state branch 2 times, most recently from 428c20b to f0d9fe5 Compare November 29, 2024 05:05
@soblin soblin marked this pull request as ready for review November 29, 2024 08:56
@soblin soblin requested a review from kosuke55 November 29, 2024 08:58
@soblin soblin force-pushed the refactor/goal-planner/move-decision-state branch from f0d9fe5 to 3492839 Compare December 2, 2024 03:02
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 2, 2024
@soblin soblin enabled auto-merge (squash) December 2, 2024 03:02
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.

Project coverage is 29.47%. Comparing base (421dcfc) to head (3492839).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_goal_planner_module/src/decision_state.cpp 0.00% 68 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9523      +/-   ##
==========================================
- Coverage   29.49%   29.47%   -0.02%     
==========================================
  Files        1442     1448       +6     
  Lines      108660   108713      +53     
  Branches    41538    41540       +2     
==========================================
  Hits        32044    32044              
- Misses      73496    73545      +49     
- Partials     3120     3124       +4     
Flag Coverage Δ *Carryforward flag
differential 0.52% <0.00%> (?)
total 29.52% <ø> (+0.03%) ⬆️ Carriedforward from 421dcfc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 557a8b5 into autowarefoundation:main Dec 2, 2024
37 of 42 checks passed
@soblin soblin deleted the refactor/goal-planner/move-decision-state branch December 2, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants