Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): remove unused arg and unavailable param file. #9525

Merged

Conversation

mbharatheesha
Copy link
Contributor

Description

This PR removes an unused launch argument from preprocessing filters in the autoware_pointcloud_preprocessor package and fixes #9524

Parent Issue:

How was this PR tested?

Removing the unused launch argument and hence unavailable path to the non-existent param file starts the filters properly. I tested this with the crop_box_filter_node.

Notes for reviewers

Interface changes

None.

ROS Parameter Changes

Removals

Change type Parameter Name Type Default Value Description
Removed filter_param_file string "$(find-pkg-share autoware_pointcloud_preprocessor/config/filter.param.yaml"

Effects on system behavior

None.

Copy link

github-actions bot commented Nov 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@vividf vividf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and your contribution!
It is a bug during refactoring.

LGTM!

@vividf vividf added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.51%. Comparing base (99e88ee) to head (cc881d8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9525      +/-   ##
==========================================
- Coverage   29.51%   29.51%   -0.01%     
==========================================
  Files        1442     1443       +1     
  Lines      108594   108626      +32     
  Branches    41502    41504       +2     
==========================================
+ Hits        32055    32059       +4     
- Misses      73418    73447      +29     
+ Partials     3121     3120       -1     
Flag Coverage Δ *Carryforward flag
differential 24.47% <ø> (?)
total 29.51% <ø> (ø) Carriedforward from 99e88ee

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vividf vividf merged commit 421dcfc into autowarefoundation:main Dec 2, 2024
51 of 53 checks passed
@mbharatheesha mbharatheesha deleted the fix-unused-param-cropbox-filter branch December 2, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unavailable param file prevents individual preprocessor nodes from starting
3 participants