Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_goal_distance_calculator)!: tier4_debug_msgs to autoware_internal_debug_msgs for autoware_goal_distance_calculator #9833

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 7, 2025

Description

I have changed the tier4_debug_msgs to autoware_internal_debug_msgs by package

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@vish0012 vish0012 requested a review from taikitanaka3 as a code owner January 7, 2025 00:38
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 30.08%. Comparing base (1586372) to head (dafab0d).
Report is 164 commits behind head on main.

Files with missing lines Patch % Lines
...e_calculator/src/goal_distance_calculator_node.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9833      +/-   ##
==========================================
- Coverage   30.08%   30.08%   -0.01%     
==========================================
  Files        1451     1451              
  Lines      108854   108864      +10     
  Branches    42744    42748       +4     
==========================================
  Hits        32752    32752              
- Misses      72900    72910      +10     
  Partials     3202     3202              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 30.08% <ø> (+<0.01%) ⬆️ Carriedforward from 1586372

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs to autoware_internal_debug_msgs for atoware_g… feat(autoware_goal_distance_calculator)!: tier4_debug_msgs to autoware_internal_debug_msgs for autoware_goal_distance_calculator Jan 17, 2025
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mitsudome-r mitsudome-r merged commit f36d072 into autowarefoundation:main Jan 22, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants