Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_image_projection_based_fusion)!: tier4_debug-msgs changed to autoware_internal_debug_msgs in autoware_image_projection_based_fusion #9877

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 9, 2025

…es perception/autoware_image_projection_based_fusion

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

Related links

autowarefoundation/autoware#5580

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

Topic changes

Modifications

Version Topic Type Topic Name Message Type Description
Old Pub //tier4_debug_msgs/float_stampede tier4_debug_msgs/FloatStamped Debug topic for float values
New Pub //autoware_internal_debug_msgs/float_stamped autoware_internal_debug_msgs/FloatStamped Updated debug topic for float values

🔴⬆️ -->

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda
Copy link
Contributor

kminoda commented Jan 9, 2025

@vish0012 Hi, thank you for your contribution.

Do you have any links for issue or discussion that you can share so that we as reviewers can understand the context more deeply?

If so, please kindly share it with us. Also, it would be helpful if you could attach that to the description.

@kminoda
Copy link
Contributor

kminoda commented Jan 9, 2025

@vish0012 Also, please change "Interface changes" part, as it includes an interface change.

@kminoda
Copy link
Contributor

kminoda commented Jan 10, 2025

@vish0012 Also, please fix the conflict.

@vish0012
Copy link
Contributor Author

@vish0012 Also, please fix the conflict.

@kminoda thank you for your comment, i have fixed the conflict

@vish0012
Copy link
Contributor Author

vish0012 commented Jan 14, 2025

@vish0012 Hi, thank you for your contribution.

Do you have any links for issue or discussion that you can share so that we as reviewers can understand the context more deeply?

If so, please kindly share it with us. Also, it would be helpful if you could attach that to the description.

@kminoda thank you for your comments

The tier4_debug_msgs package currently contains message definitions (e.g., BoolStamped, Int32Stamped) used for debugging in Autoware. To align with Autoware Foundation's standards and improve maintainability, these messages need to be moved to a new package, autoware_internal_debug_msgs, under the autoware_internal_msgs repository.

Goals:

Create a new ROS package autoware_internal_debug_msgs under the autoware_internal_msgs repository.
Move all messages from tier4_debug_msgs to the new package.
Update the code in autoware.universe to reference autoware_internal_debug_msgs instead of tier4_debug_msgs.

@mitsudome-r mitsudome-r changed the title feat: tier4_debug-msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_image_projection_based_fusion): tier4_debug-msgs changed to autoware_internal_debug_msgs in fil… Jan 14, 2025
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2025
@mitsudome-r mitsudome-r changed the title feat(autoware_image_projection_based_fusion): tier4_debug-msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_image_projection_based_fusion)!: tier4_debug-msgs changed to autoware_internal_debug_msgs in autoware_image_projection_based_fusion Jan 17, 2025
@mitsudome-r
Copy link
Member

@vish0012
Could you also add the new dependency to autoware_internal_debug_msgs in package.xml?
https://github.com/autowarefoundation/autoware.universe/blob/main/perception/autoware_image_projection_based_fusion/package.xml

…es perception/autoware_image_projection_based_fusion

Signed-off-by: vish0012 <[email protected]>
@mitsudome-r mitsudome-r force-pushed the replace_debug_msgs_image_projection_based_fusion branch from 4248510 to 2383abd Compare January 21, 2025 05:40
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.20%. Comparing base (b7b3dd6) to head (ee93597).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
..._image_projection_based_fusion/src/fusion_node.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9877      +/-   ##
==========================================
+ Coverage   29.18%   29.20%   +0.01%     
==========================================
  Files        1410     1411       +1     
  Lines      107239   107178      -61     
  Branches    42481    42474       -7     
==========================================
+ Hits        31300    31301       +1     
+ Misses      72720    72658      -62     
  Partials     3219     3219              
Flag Coverage Δ *Carryforward flag
differential 3.52% <0.00%> (?)
differential-cuda 2.53% <0.00%> (?)
total 29.21% <ø> (+0.02%) ⬆️ Carriedforward from 2383abd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

3 participants