-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_image_projection_based_fusion)!: tier4_debug-msgs changed to autoware_internal_debug_msgs in autoware_image_projection_based_fusion #9877
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@vish0012 Hi, thank you for your contribution. Do you have any links for issue or discussion that you can share so that we as reviewers can understand the context more deeply? If so, please kindly share it with us. Also, it would be helpful if you could attach that to the description. |
@vish0012 Also, please change "Interface changes" part, as it includes an interface change. |
@vish0012 Also, please fix the conflict. |
The tier4_debug_msgs package currently contains message definitions (e.g., BoolStamped, Int32Stamped) used for debugging in Autoware. To align with Autoware Foundation's standards and improve maintainability, these messages need to be moved to a new package, autoware_internal_debug_msgs, under the autoware_internal_msgs repository. Goals: Create a new ROS package autoware_internal_debug_msgs under the autoware_internal_msgs repository. |
perception/autoware_image_projection_based_fusion/src/fusion_node.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_image_projection_based_fusion/src/fusion_node.cpp
Outdated
Show resolved
Hide resolved
@vish0012 |
…es perception/autoware_image_projection_based_fusion Signed-off-by: vish0012 <[email protected]>
4248510
to
2383abd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9877 +/- ##
==========================================
+ Coverage 29.18% 29.20% +0.01%
==========================================
Files 1410 1411 +1
Lines 107239 107178 -61
Branches 42481 42474 -7
==========================================
+ Hits 31300 31301 +1
+ Misses 72720 72658 -62
Partials 3219 3219
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…es perception/autoware_image_projection_based_fusion
Description
The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.
Related links
autowarefoundation/autoware#5580
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
Topic changes
Modifications
//tier4_debug_msgs/float_stampede
tier4_debug_msgs/FloatStamped
//autoware_internal_debug_msgs/float_stamped
autoware_internal_debug_msgs/FloatStamped
🔴⬆️ -->
Effects on system behavior
None.