feat(diagnostic_graph_utils): remove unnecessary dependency in diagnostic_graph_utils #9922
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es system/diagnostic_graph_utils Signed-off-by: vish0012 <[email protected]>
github-actions
bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
added
the
run:build-and-test-differential
mitsudome-r
changed the title
mitsudome-r
reviewed
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9922 +/- ##
==========================================
+ Coverage 29.18% 29.24% +0.06%
==========================================
Files 1410 1413 +3
Lines 107239 107179 -60
Branches 42481 42451 -30
==========================================
+ Hits 31300 31349 +49
+ Misses 72720 72605 -115
- Partials 3219 3225 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It seems like this most of the modification was already fixed in #9741 |
mitsudome-r
changed the title
|
I have changed the title to just change the package xml to remove the dependency to unused tier4_debug_msgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.
autowarefoundation/autoware#5580
Related links
autowarefoundation/autoware#5580
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.