Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_accel_brake_map_calibrator)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_accel_brake_map_calibrator #9923

Conversation

vish0012
Copy link
Contributor

…es vehicle/autoware_accel_brake_map_calibrator

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

autowarefoundation/autoware#5580

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…es vehicle/autoware_accel_brake_map_calibrator

Signed-off-by: vish0012 <[email protected]>
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2025
@taikitanaka3
Copy link
Contributor

@vish0012
Thank you for PR but please fix pr message and add ! if you change message in nodes

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.13%. Comparing base (74f6779) to head (4c32356).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9923      +/-   ##
==========================================
- Coverage   29.13%   29.13%   -0.01%     
==========================================
  Files        1425     1426       +1     
  Lines      107845   107866      +21     
  Branches    42249    42248       -1     
==========================================
+ Hits        31416    31422       +6     
- Misses      73386    73400      +14     
- Partials     3043     3044       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.13% <ø> (+<0.01%) ⬆️ Carriedforward from 7bc6a4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs chnaged to autoware_internal_debug_msgs in fil… feat(autoware_accel_brake_map_calibrator)!: tier4_debug_msgs chnaged to autoware_internal_debug_msgs in autoware_accel_brake_map_calibrator Jan 17, 2025
@mitsudome-r
Copy link
Member

@taikitanaka3

Thank you for PR but please fix pr message and add ! if you change message in nodes

I have updated the PR title.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r changed the title feat(autoware_accel_brake_map_calibrator)!: tier4_debug_msgs chnaged to autoware_internal_debug_msgs in autoware_accel_brake_map_calibrator feat(autoware_accel_brake_map_calibrator)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_accel_brake_map_calibrator Jan 17, 2025
@mitsudome-r mitsudome-r merged commit e3e7fdb into autowarefoundation:main Jan 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants