fix(map_based_prediction): fix unintentional accumulation of lanelets #9950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
PredictorVru::setLaneletMap
, it will always accumulate the crosswalk or walkways lanelets when map gets updated.It may work trouble-free with the current implementation in the current Autoware architecture, where the map is provided only once.
But in multiple map case (loading map like mapA -> mapB -> mapA -> ... for moving between 2 regions), it may potentially cause some extra latency since it will
linear scan the lanelets for each targeted objects: https://github.com/autowarefoundation/autoware_lanelet2_extension/blob/c8ff315d21fc2e62329a7272e3d49edfa88fc57e/autoware_lanelet2_extension/lib/query.cpp#L885
Related links
Parent Issue:
How was this PR tested?
Checked the logging simulator using the sample ROS bag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.