Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_based_prediction): fix unintentional accumulation of lanelets #9950

Conversation

a-maumau
Copy link
Contributor

Description

In PredictorVru::setLaneletMap, it will always accumulate the crosswalk or walkways lanelets when map gets updated.
It may work trouble-free with the current implementation in the current Autoware architecture, where the map is provided only once.
But in multiple map case (loading map like mapA -> mapB -> mapA -> ... for moving between 2 regions), it may potentially cause some extra latency since it will
linear scan the lanelets for each targeted objects: https://github.com/autowarefoundation/autoware_lanelet2_extension/blob/c8ff315d21fc2e62329a7272e3d49edfa88fc57e/autoware_lanelet2_extension/lib/query.cpp#L885

Related links

Parent Issue:

  • Link

How was this PR tested?

Checked the logging simulator using the sample ROS bag.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: a-maumau <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 17, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin self-assigned this Jan 17, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2025
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (01a7647) to head (be84c11).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...utoware_map_based_prediction/src/predictor_vru.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9950      +/-   ##
==========================================
- Coverage   29.23%   29.22%   -0.01%     
==========================================
  Files        1425     1427       +2     
  Lines      107740   107776      +36     
  Branches    42197    42200       +3     
==========================================
  Hits        31496    31496              
- Misses      73198    73234      +36     
  Partials     3046     3046              
Flag Coverage Δ *Carryforward flag
differential 1.92% <0.00%> (?)
differential-cuda 1.92% <0.00%> (?)
total 29.23% <ø> (ø) Carriedforward from 01a7647

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit 7bc6a4e into autowarefoundation:main Jan 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants