Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): add pass marker #9952

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 17, 2025

Description

  1. add pass marker
    image

  2. suppress frequent message

Related links

#9940

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: yuki-takagi-66 <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:require-cuda-build-and-test labels Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.13%. Comparing base (7bc6a4e) to head (225121a).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9952   +/-   ##
=======================================
  Coverage   29.13%   29.13%           
=======================================
  Files        1425     1426    +1     
  Lines      107845   107865   +20     
  Branches    42249    42248    -1     
=======================================
+ Hits        31422    31430    +8     
- Misses      73379    73394   +15     
+ Partials     3044     3041    -3     
Flag Coverage Δ *Carryforward flag
differential 19.10% <0.00%> (?)
total 29.13% <ø> (+<0.01%) ⬆️ Carriedforward from 7bc6a4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit ce3358e into autowarefoundation:main Jan 21, 2025
62 of 66 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/crosswalk/add-pass-marker branch January 21, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants