Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ekf_localizer)!: porting from universe to core #9978

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Jan 20, 2025

Description

We are porting autoware_ekf_localizer to autoware.core, and this PR remove the package from universe

Related links

Parent Issue:

How was this PR tested?

  1. Clone & Build autoware main branch
  2. Change version on autoware.core(feat(autoware_ekf_localizer)!: porting from universe to core autoware.core#174) and autoware.universe(this PR) under the "src" dir
  3. Rebuild autoware_ekf_localizer only
  4. Relpay sample rosbag
  5. Confirm the behavior is alright.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.47%. Comparing base (ae436b3) to head (c4045a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9978      +/-   ##
==========================================
- Coverage   29.47%   29.47%   -0.01%     
==========================================
  Files        1424     1424              
  Lines      107880   107887       +7     
  Branches    42827    42830       +3     
==========================================
  Hits        31801    31801              
- Misses      73010    73017       +7     
  Partials     3069     3069              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.47% <ø> (ø) Carriedforward from ae436b3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Motsu-san Motsu-san changed the title feat(autoware_ekf_localizer): porting from universe to core feat(autoware_ekf_localizer)!: porting from universe to core Jan 20, 2025
@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from 0eb26d4 to c4045a0 Compare January 20, 2025 08:10
@Motsu-san
Copy link
Contributor Author

@meliketanrikulu Could you review the change on localization/autoware_pose_covariance_modifier/README.md?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick response.

@Motsu-san Motsu-san merged commit 037c315 into autowarefoundation:main Jan 20, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants