Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_redundancy_relay_manager): add redundancy relay manager node #9981

style(pre-commit): autofix

d8d44a7
Select commit
Loading
Failed to load commit list.
Closed

feat(autoware_redundancy_relay_manager): add redundancy relay manager node #9981

style(pre-commit): autofix
d8d44a7
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 20, 2025 in 51s

CodeScene PR Check

Code Health Quality Gates: OK

Code Health of new files: 9.21

  • Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method redundancy_relay_manager_node.cpp: RedundancyRelayManager::onSubElectionStatus
  • Complex Method redundancy_relay_manager_node.cpp: RedundancyRelayManager::onMainElectionStatus
  • Bumpy Road Ahead redundancy_relay_manager_node.cpp: RedundancyRelayManager::onMainElectionStatus
  • Bumpy Road Ahead redundancy_relay_manager_node.cpp: RedundancyRelayManager::onSubElectionStatus

Annotations

Check warning on line 110 in system/autoware_redundancy_relay_manager/src/redundancy_relay_manager_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

RedundancyRelayManager::onSubElectionStatus has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 79 in system/autoware_redundancy_relay_manager/src/redundancy_relay_manager_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

RedundancyRelayManager::onMainElectionStatus has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 79 in system/autoware_redundancy_relay_manager/src/redundancy_relay_manager_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

RedundancyRelayManager::onMainElectionStatus has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 110 in system/autoware_redundancy_relay_manager/src/redundancy_relay_manager_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

RedundancyRelayManager::onSubElectionStatus has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.