Skip to content

feat: improved data handling in the ogm. When using the full concaten…

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 31, 2025 in 33s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.06 (9.41 -> 9.47)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method pointcloud_based_occupancy_grid_map_node.cpp: PointcloudBasedOccupancyGridMapNode::PointcloudBasedOccupancyGridMapNode

✅ Improving Code Health:

  • Large Method occupancy_grid_map_fixed.cpp: OccupancyGridMapFixedBlindSpot::updateWithPointCloud

Annotations

Check notice on line 158 in perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Large Method 

OccupancyGridMapFixedBlindSpot::updateWithPointCloud is no longer above the threshold for lines of code

Check warning on line 157 in perception/autoware_probabilistic_occupancy_grid_map/src/pointcloud_based_occupancy_grid_map/pointcloud_based_occupancy_grid_map_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

PointcloudBasedOccupancyGridMapNode::PointcloudBasedOccupancyGridMapNode increases from 82 to 83 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis