Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-prs-to-update-vcs-repositories): add a workflow #5295

Conversation

sasakisasaki
Copy link
Collaborator

@sasakisasaki sasakisasaki commented Oct 1, 2024

Description

This PR adds a new feature as follows:

  • Check the version of all repositories in the autoware.repos
  • Check if the version of the repository is the latest
  • If the version is not the latest, create a PR to update the repository to the latest version
    • This PR will be created for each repository that is not the latest version
  • We can specify which updates the PR should be created for.
    • In this PR, I selected major and minor.

Related links

Semantic Versioning Discussion
Discussion in the autoware-github-actions

Tests performed (Referenced from the URL in "Related links")

Same as tests performed in this PR except following points:

  • We tested the version update PRs are created in the following cases:
    0.0.1  =>  0.0.2    # If `--targets patch` is used
    1.1.1  =>  1.2.1    # If `--targets minor` is used
    2.0.9  =>  3.1.4    # If `--targets major` is used
  • Also we tested the version update PR is not created if the following examples:
    main       =>  0.0.1
    v0.0.1     =>  0.0.2
    xxx-0.0.1  =>  0.0.9

To know the detail of performed tests, please see the description of this PR.

Notes for reviewers

After this PR is merged, PRs for version update will be created automatically.
Perhaps we need to adjust the cron schedule here to prevent from noisy PR creation.

Interface changes

No interface changes.

ROS Topic Changes

No ROS topic changes.

ROS Parameter Changes

No ROS parameter changes.

Effects on system behavior

New PRs will be created as the vcs repository has update with the expected format of version (e.g., 0.0.2, 0.1.2, 1.2.3).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@sasakisasaki sasakisasaki marked this pull request as ready for review October 2, 2024 05:17
@sasakisasaki
Copy link
Collaborator Author

@youtalk Now this PR is ready for review 👍

@sasakisasaki sasakisasaki self-assigned this Oct 2, 2024
@sasakisasaki sasakisasaki added type:new-feature New functionalities or additions, feature requests. type:github-actions Github actions related. (auto-assigned) labels Oct 2, 2024
@sasakisasaki
Copy link
Collaborator Author

@youtalk I believe this PR is ready for merge. Your review is appreciated.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM finally!

@youtalk youtalk enabled auto-merge (squash) October 3, 2024 05:43
@youtalk youtalk added the tag:run-health-check Run health-check label Oct 4, 2024
@youtalk youtalk merged commit 1c82af0 into autowarefoundation:main Oct 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:github-actions Github actions related. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants