-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-prs-to-update-vcs-repositories): add a workflow #5295
Merged
youtalk
merged 4 commits into
autowarefoundation:main
from
sasakisasaki:feat-add-a-fixed-workflow-to-create-prs-to-update-vcs-repositories
Oct 4, 2024
Merged
feat(create-prs-to-update-vcs-repositories): add a workflow #5295
youtalk
merged 4 commits into
autowarefoundation:main
from
sasakisasaki:feat-add-a-fixed-workflow-to-create-prs-to-update-vcs-repositories
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junya Sasaki <[email protected]>
@youtalk Now this PR is ready for review 👍 |
youtalk
reviewed
Oct 2, 2024
sasakisasaki
added
type:new-feature
New functionalities or additions, feature requests.
type:github-actions
Github actions related. (auto-assigned)
labels
Oct 2, 2024
Signed-off-by: Junya Sasaki <[email protected]>
@youtalk I believe this PR is ready for merge. Your review is appreciated. |
youtalk
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM finally!
…pdate-vcs-repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
tag:run-health-check
Run health-check
type:github-actions
Github actions related. (auto-assigned)
type:new-feature
New functionalities or additions, feature requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new feature as follows:
major
andminor
.Related links
Semantic Versioning Discussion
Discussion in the autoware-github-actions
Tests performed (Referenced from the URL in "Related links")
Same as tests performed in this PR except following points:
To know the detail of performed tests, please see the description of this PR.
Notes for reviewers
After this PR is merged, PRs for version update will be created automatically.
Perhaps we need to adjust the cron schedule here to prevent from noisy PR creation.
Interface changes
No interface changes.
ROS Topic Changes
No ROS topic changes.
ROS Parameter Changes
No ROS parameter changes.
Effects on system behavior
New PRs will be created as the vcs repository has update with the expected format of version (e.g., 0.0.2, 0.1.2, 1.2.3).
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.