-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(.github): update github-release
workflow
#5652
fix(.github): update github-release
workflow
#5652
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
github-release
actiongithub-release
action
github-release
actiongithub-release
workflow
github-release
workflowgithub-release
workflow
I think these are may cause some mild problems in the future:
What do you think ? @youtalk |
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@oguzkaganozt I've applied your suggestion. Please review again. The test was also passed. https://github.com/youtalk/autoware/actions/runs/12821081649/job/35751719529 |
I think we can make the update to sync-file-template instead. We are probably going to use it for all the other repositories as well. autoware/.github/workflows/github-release.yaml Lines 1 to 3 in 3dad554
|
Only |
Description
This PR fixes the
github-release
workflow so that the GitHub release page is correctly generated when a version tag is pushed.How was this PR tested?
The result of executing a
workflow_dispatch
trigger withtag-name
set to0.40.0
in my forked repository:https://github.com/youtalk/autoware/releases/tag/untagged-abca71c3a111e29fae42
Notes for reviewers
None.
Effects on system behavior
None.