Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): update github-release workflow #5652

Closed

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 14, 2025

Description

This PR fixes the github-release workflow so that the GitHub release page is correctly generated when a version tag is pushed.

How was this PR tested?

The result of executing a workflow_dispatch trigger with tag-name set to 0.40.0 in my forked repository:

https://github.com/youtalk/autoware/releases/tag/untagged-abca71c3a111e29fae42

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk closed this Jan 14, 2025
@youtalk youtalk deleted the chore/update-github-release branch January 14, 2025 08:12
Copy link

github-actions bot commented Jan 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk restored the chore/update-github-release branch January 14, 2025 08:13
@youtalk youtalk deleted the chore/update-github-release branch January 14, 2025 08:13
@youtalk youtalk restored the chore/update-github-release branch January 14, 2025 08:13
@youtalk youtalk reopened this Jan 14, 2025
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk changed the title chore(.github): update github-release action docs(.github): fix github-release action Jan 14, 2025
@youtalk youtalk changed the title docs(.github): fix github-release action docs(.github): fix github-release workflow Jan 14, 2025
@youtalk youtalk changed the title docs(.github): fix github-release workflow fix(.github): update github-release workflow Jan 14, 2025
@youtalk youtalk marked this pull request as ready for review January 14, 2025 12:33
@youtalk youtalk requested a review from oguzkaganozt as a code owner January 14, 2025 12:33
@youtalk youtalk requested review from xmfcx and mitsudome-r January 14, 2025 12:33
@youtalk youtalk self-assigned this Jan 14, 2025
@youtalk youtalk added type:github-actions Github actions related. (auto-assigned) tag:run-health-check Run health-check labels Jan 14, 2025
@oguzkaganozt
Copy link
Contributor

I think these are may cause some mild problems in the future:

  • Version tags are not specific enough maybe we can make it more specific with something like "v[0-9]+.[0-9]+.[0-9]+"
  • Removal of --target parameter may cause releases to be associated with unexpected commits

What do you think ? @youtalk

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
Copy link
Member Author

youtalk commented Jan 17, 2025

@oguzkaganozt I've applied your suggestion. Please review again.
c8b5091 2f050e5

The test was also passed. https://github.com/youtalk/autoware/actions/runs/12821081649/job/35751719529

@mitsudome-r
Copy link
Member

I think we can make the update to sync-file-template instead. We are probably going to use it for all the other repositories as well.
If there are some changes that should be applied to this repository only, we might want to remove the comments at the top:

# This file is automatically synced from:
# https://github.com/autowarefoundation/sync-file-templates
# To make changes, update the source repository and follow the guidelines in its README.

@youtalk
Copy link
Member Author

youtalk commented Jan 22, 2025

Only tier4/autoware.universe and tier4/autoware_launch are needed to operate with the original workflow definition. Therefore, I plan to first exclude them from sync-files and then modify the sync-file-template.

@youtalk youtalk closed this Jan 22, 2025
@youtalk youtalk deleted the chore/update-github-release branch January 22, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:github-actions Github actions related. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants