Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): add set -e to return shell script's error #5661

Merged
merged 5 commits into from
Jan 21, 2025
Merged

fix(docker): add set -e to return shell script's error #5661

merged 5 commits into from
Jan 21, 2025

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 16, 2025

Description

This PR fixes the issue where the shell scripts invoked during docker build returns an error, but the docker build process continues.
For example, there was the following issue where the execution continued even if dependency packages were not found with rosdep keys.

#5586 (comment)

ERROR: no rosdep rule for 'automatic_pose_initializer'
ERROR: no rosdep rule for 'autoware_pointcloud_preprocessor'

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@youtalk
add set
876428e 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk marked this pull request as ready for review January 16, 2025 13:01
@youtalk youtalk requested a review from oguzkaganozt as a code owner January 16, 2025 13:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk self-assigned this Jan 16, 2025
@youtalk youtalk requested review from xmfcx and mitsudome-r January 16, 2025 13:02
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Jan 16, 2025
@youtalk
Copy link
Member Author

youtalk commented Jan 17, 2025

@mitsudome-r @xmfcx @oguzkaganozt Please review this. It will be very helpful to test them.

@youtalk youtalk changed the title fix(docker): add set -euo pipefail to return shell script's error fix(docker): add set -e to return shell script's error Jan 17, 2025
@youtalk youtalk merged commit 7e68dc8 into main Jan 21, 2025
19 checks passed
@youtalk youtalk deleted the fix/shell-script-header branch January 21, 2025 08:40
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 22, 2025
Open
@youtalk youtalk mentioned this pull request Jan 27, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

@xmfcx xmfcx Awaiting requested review from xmfcx

Assignees

@youtalk youtalk

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtalk @mitsudome-r